Build broken on Windows (VS2017) #128

targos · 2019-12-04T14:37:02Z

https://ci.nodejs.org/job/node-compile-windows/30296/nodes=win-vs2017/console

11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::FreeSpace': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\class-definitions-tq.h(107): note: see declaration of 'v8::internal::FreeSpace'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::FreeSpace
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(1224): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::FreeSpace,v8::internal::FreeSpace>' being compiled
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\x64\register-x64.h(153): note: see reference to class template instantiation 'v8::internal::RegisterBase<v8::internal::XMMRegister,16>' being compiled
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\x64\register-x64.h(53): note: see reference to class template instantiation 'v8::internal::RegisterBase<v8::internal::Register,16>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSRegExpStringIterator': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(59): note: see declaration of 'v8::internal::JSRegExpStringIterator'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSRegExpStringIterator
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(1566): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSRegExpStringIterator,v8::internal::JSRegExpStringIterator>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::SyntheticModule': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\heap\factory.h(66): note: see declaration of 'v8::internal::SyntheticModule'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::SyntheticModule
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(2460): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::SyntheticModule,v8::internal::SyntheticModule>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::TemplateObjectDescription': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\heap\factory.h(67): note: see declaration of 'v8::internal::TemplateObjectDescription'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::TemplateObjectDescription
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(2478): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::TemplateObjectDescription,v8::internal::TemplateObjectDescription>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSDateTimeFormat': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(53): note: see declaration of 'v8::internal::JSDateTimeFormat'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSDateTimeFormat
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3066): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSDateTimeFormat,v8::internal::JSDateTimeFormat>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSDisplayNames': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(54): note: see declaration of 'v8::internal::JSDisplayNames'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSDisplayNames
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3102): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSDisplayNames,v8::internal::JSDisplayNames>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSListFormat': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(55): note: see declaration of 'v8::internal::JSListFormat'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSListFormat
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3114): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSListFormat,v8::internal::JSListFormat>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSNumberFormat': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(57): note: see declaration of 'v8::internal::JSNumberFormat'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSNumberFormat
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3132): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSNumberFormat,v8::internal::JSNumberFormat>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSPluralRules': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(58): note: see declaration of 'v8::internal::JSPluralRules'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSPluralRules
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3162): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSPluralRules,v8::internal::JSPluralRules>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSRelativeTimeFormat': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(60): note: see declaration of 'v8::internal::JSRelativeTimeFormat'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSRelativeTimeFormat
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3186): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSRelativeTimeFormat,v8::internal::JSRelativeTimeFormat>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSLocale': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(56): note: see declaration of 'v8::internal::JSLocale'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSLocale
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3210): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSLocale,v8::internal::JSLocale>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSSegmenter': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(62): note: see declaration of 'v8::internal::JSSegmenter'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSSegmenter
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3216): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSSegmenter,v8::internal::JSSegmenter>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSSegmentIterator': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(61): note: see declaration of 'v8::internal::JSSegmentIterator'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSSegmentIterator
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3234): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSSegmentIterator,v8::internal::JSSegmentIterator>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSV8BreakIterator': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(63): note: see declaration of 'v8::internal::JSV8BreakIterator'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSV8BreakIterator
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3252): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSV8BreakIterator,v8::internal::JSV8BreakIterator>' being compiled
11:00:47 c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.16.27023\include\type_traits(616): error C2139: 'v8::internal::JSCollator': an undefined class is not allowed as an argument to compiler intrinsic type trait '__is_convertible_to' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers.vcxproj]
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.h(51): note: see declaration of 'v8::internal::JSCollator'
11:00:47   c:\workspace\node-compile-windows\node\deps\v8\src\codegen\tnode.h(244): note: see reference to class template instantiation 'std::is_convertible<T,v8::internal::Object>' being compiled
11:00:47           with
11:00:47           [
11:00:47               T=v8::internal::JSCollator
11:00:47           ]
11:00:47   c:\workspace\node-compile-windows\node\out\release\obj\global_intermediate\torque-output-root\torque-generated\exported-macros-assembler-tq.cc(3306): note: see reference to class template instantiation 'v8::internal::is_subtype<v8::internal::JSCollator,v8::internal::JSCollator>' being compiled

The text was updated successfully, but these errors were encountered:

targos · 2019-12-10T13:39:59Z

/cc @nodejs/platform-windows

gengjiawen · 2020-01-18T03:37:02Z

Thought on add visual studio 2017 to github action ?

cclauss · 2020-01-18T05:19:21Z

Both Visual Studio 2017 and 2019 are available on GitHub Actions if you want to take a shot at it.

gengjiawen · 2020-01-18T07:07:25Z

Both Visual Studio 2017 and 2019 are available on GitHub Actions if you want to take a shot at it.

Yeap. But I want github action only do the least job. We have jenkins for full CI.
Maybe only add vs2017 to this repo only ? cc @targos @richardlau

targos · 2020-01-18T07:10:30Z

What kind of information could a github action give us that's not already part of our CI job result?

gengjiawen · 2020-01-18T07:14:25Z

What kind of information could a github action give us that's not already part of our CI job result?

Automatically trigger for PR and push.

Also the build log won't lost. ci.nodejs.org/job/node-compile-windows/30296/nodes=win-vs2017/console is broken.

But I am quite insist on this, we got vs2019 on github action anyway.

richardlau · 2020-01-18T09:12:09Z

The GitHub runner containing VS2017 is being removed soon:

Note: The Windows Server 2016 virtual environment will be removed in January 2020.

https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners#windows-server-2016

richardlau · 2020-01-18T09:28:30Z

(Also our Windows builds using GitHub Actions are broken at the moment failing to install nasm.)

gengjiawen · 2020-01-18T09:32:10Z

(Also our Windows builds using GitHub Actions are broken at the moment failing to install nasm.)

Yeap, there websites is down.

gengjiawen · 2020-01-18T10:02:05Z

Looks like this happen multi times microsoft/vcpkg#2777

gengjiawen · 2020-02-26T10:12:25Z

current error on visual studio 2017:

[00:41:30] objects-printer-tq.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] class-verifiers-tq.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] simulator-base.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] perf-jit.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] objects-debug.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] gdb-jit.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] tnode.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:30] constant-pool.obj : warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library [C:\projects\appveyor-playground\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
[00:41:31]   v8_base_without_compiler.vcxproj -> ..\..\out\Release\lib\v8_base_without_compiler.lib

gengjiawen · 2020-02-27T13:14:26Z

New fix: #143.

Node.js build fails on VS2017 without these headers, see the downstream issue (nodejs/node-v8#128). Co-authored-by: Ben Noordhuis <[email protected]> Co-authored-by: gengjiawen <[email protected]> Change-Id: I771eab435dce5cf548581f3acd78681180c77692 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093951 Reviewed-by: Tobias Tebbi <[email protected]> Commit-Queue: Tobias Tebbi <[email protected]> Cr-Commit-Position: refs/heads/master@{#66661}

Original commit message: [torque] fix build on VS2017 Node.js build fails on VS2017 without these headers, see the downstream issue (nodejs/node-v8#128). Co-authored-by: Ben Noordhuis <[email protected]> Co-authored-by: gengjiawen <[email protected]> Change-Id: I771eab435dce5cf548581f3acd78681180c77692 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093951 Reviewed-by: Tobias Tebbi <[email protected]> Commit-Queue: Tobias Tebbi <[email protected]> Cr-Commit-Position: refs/heads/master@{#66661} Refs: v8/v8@931bdbd

Original commit message: [torque] fix build on VS2017 Node.js build fails on VS2017 without these headers, see the downstream issue (#128). Co-authored-by: Ben Noordhuis <[email protected]> Co-authored-by: gengjiawen <[email protected]> Change-Id: I771eab435dce5cf548581f3acd78681180c77692 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093951 Reviewed-by: Tobias Tebbi <[email protected]> Commit-Queue: Tobias Tebbi <[email protected]> Cr-Commit-Position: refs/heads/master@{#66661} Refs: v8/v8@931bdbd

Original commit message: [torque] fix build on VS2017 Node.js build fails on VS2017 without these headers, see the downstream issue (nodejs/node-v8#128). Co-authored-by: Ben Noordhuis <[email protected]> Co-authored-by: gengjiawen <[email protected]> Change-Id: I771eab435dce5cf548581f3acd78681180c77692 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093951 Reviewed-by: Tobias Tebbi <[email protected]> Commit-Queue: Tobias Tebbi <[email protected]> Cr-Commit-Position: refs/heads/master@{#66661} Refs: v8/v8@931bdbd

Original commit message: [torque] fix build on VS2017 Node.js build fails on VS2017 without these headers, see the downstream issue (#128). Co-authored-by: Ben Noordhuis <[email protected]> Co-authored-by: gengjiawen <[email protected]> Change-Id: I771eab435dce5cf548581f3acd78681180c77692 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093951 Reviewed-by: Tobias Tebbi <[email protected]> Commit-Queue: Tobias Tebbi <[email protected]> Cr-Commit-Position: refs/heads/master@{#66661} Refs: v8/v8@931bdbd

Original commit message: [torque] fix build on VS2017 Node.js build fails on VS2017 without these headers, see the downstream issue (nodejs/node-v8#128). Co-authored-by: Ben Noordhuis <[email protected]> Co-authored-by: gengjiawen <[email protected]> Change-Id: I771eab435dce5cf548581f3acd78681180c77692 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093951 Reviewed-by: Tobias Tebbi <[email protected]> Commit-Queue: Tobias Tebbi <[email protected]> Cr-Commit-Position: refs/heads/master@{#66661} Refs: v8/v8@931bdbd PR-URL: #32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

targos mentioned this issue Dec 4, 2019

Blockers for the update to V8 8.0 #127

Closed

11 tasks

bnoordhuis mentioned this issue Jan 2, 2020

v8: include right headers in torque output #133

Closed

targos mentioned this issue Jan 13, 2020

No Windows builds since 2019.11.07 #121

Closed

gengjiawen mentioned this issue Feb 27, 2020

v8: include right headers in torque output #143

Closed

targos closed this as completed Feb 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build broken on Windows (VS2017) #128

Build broken on Windows (VS2017) #128

targos commented Dec 4, 2019

targos commented Dec 10, 2019

gengjiawen commented Jan 18, 2020

cclauss commented Jan 18, 2020 •

edited

Loading

gengjiawen commented Jan 18, 2020

targos commented Jan 18, 2020

gengjiawen commented Jan 18, 2020

richardlau commented Jan 18, 2020

richardlau commented Jan 18, 2020

gengjiawen commented Jan 18, 2020

gengjiawen commented Jan 18, 2020

gengjiawen commented Feb 26, 2020

gengjiawen commented Feb 27, 2020

Build broken on Windows (VS2017) #128

Build broken on Windows (VS2017) #128

Comments

targos commented Dec 4, 2019

targos commented Dec 10, 2019

gengjiawen commented Jan 18, 2020

cclauss commented Jan 18, 2020 • edited Loading

gengjiawen commented Jan 18, 2020

targos commented Jan 18, 2020

gengjiawen commented Jan 18, 2020

richardlau commented Jan 18, 2020

richardlau commented Jan 18, 2020

gengjiawen commented Jan 18, 2020

gengjiawen commented Jan 18, 2020

gengjiawen commented Feb 26, 2020

gengjiawen commented Feb 27, 2020

cclauss commented Jan 18, 2020 •

edited

Loading