http - http.ClientRequest doesn't emit 'aborted'?

[ronag]

Looking through the _http_client.js code it seems to me that the http.ClientRequest object never emits an ´aborted´ event (only close). It's just the response object that emits the aborted event.

https://github.com/nodejs/node/blob/master/lib/_http_client.js#L366

That seems to go against the docs, https://nodejs.org/api/http.html#http_event_aborted

[bnoordhuis]

Yes, it's incorrect. It may have been copy/pasted from http.IncomingMessage, which does emit it.

[odeke-em]

For posterity @ronag I am pasting in the permalink of the line that you referenced in code

node/lib/_http_client.js

Line 366 in c79fd2b

req.res.emit('aborted');

so that when the code is shuffled around, we can always refer to it.

Also this issue precedes and seems like it is related to #15283, should we be folding #15283 in here?

[lpinca]

The documentation for this event should be moved to http.ServerResponse.

Edit: nvm.