npm throws an error on master

[evanlucas]

Looks like a regression introduced in 6d95f4f.

$ npm
module.js:334
    throw err;
          ^
Error: Cannot find module 'internal/smalloc'
    at Function.Module._resolveFilename (module.js:332:15)
    at Function.Module._load (module.js:282:25)
    at Module.require (module.js:361:17)
    at require (module.js:380:17)
    at evalmachine.<anonymous>:22:20
    at Object.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/graceful-fs/fs.js:11:1)
    at Module._compile (module.js:426:26)
    at Object.Module._extensions..js (module.js:444:10)
    at Module.load (module.js:351:32)
    at Function.Module._load (module.js:306:12)

/cc @vkurchatkin

[targos]

It is caused by this change in fs.js.

It breaks graceful-fs which is evaluating the code from fs in a context where internal modules are not allowed.

[targos]

/cc @isaacs

[vkurchatkin]

// eeeeeevvvvviiiiiiillllll
// more evil than monkey-patching the native builtin?
// Not sure

Well, now we know the answer

[thefourtheye]

I wonder why this was not caught when I ran make test with this change. This is not covered in testcases?

[bnoordhuis]

@thefourtheye make test doesn't run make test-npm (yet? there was talk about that recently.)

[thefourtheye]

@bnoordhuis But, requiring fs in other modules should have failed, right?

[bnoordhuis]

When you say 'other modules', do you mean 'core modules'? Those have access to internal modules so no problem there. require('fs') in user code isn't affected either.

The npm breakage is because graceful-fs does eval(process.binding('natives').fs). It's completely unsupported and normally I'd say 'tough luck'. But a broken npm is bad so we'll have to add a workaround until graceful-fs gets fixed.