We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
setHost: true
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v9.8.0
node/lib/_http_client.js
Line 141 in 27ba6e2
This should be options.setHost !== false so I can do the following:
options.setHost !== false
https.request({ setHost: opts.host !== false }, cb)
Currently, I have to do the following:
let config = {} if (opts.host === false) { config.setHost = false } https.request(config, cb)
In other words, setting setHost to true causes the "Host" header to not be set to a default value. This is confusing behavior.
setHost
true
The text was updated successfully, but these errors were encountered:
http: fix request when setHost is true
request
867fee8
Fixes: nodejs#19457
b06f686
e1f44a6
Fixes: #19457 PR-URL: #19502 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Successfully merging a pull request may close this issue.
v9.8.0
node/lib/_http_client.js
Line 141 in 27ba6e2
This should be
options.setHost !== false
so I can do the following:Currently, I have to do the following:
In other words, setting
setHost
totrue
causes the "Host" header to not be set to a default value. This is confusing behavior.The text was updated successfully, but these errors were encountered: