Closed
Description
On Windows with MSVC, the implementation of StringSearch<Char>::BoyerMooreHorspoolSearch
emits a concerning warning.
Code:
Lines 459 to 461 in fd02dac
The emitted warning is C4146: unary minus operator applied to unsigned type, result still unsigned
This looks like it introduces a bug in the function, at least on Windows, because badness
is never going to be a negative number.