Skip to content

Compiler failure with VS 2022 and V8 9.3 #39976

Closed
@targos

Description

@targos

Unfortunately, #39857 landed after the V8 9.3 update, but tests were run when our code was still on V8 9.2.

Error:

     Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp
mksnapshot.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-aix.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-generic.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-mac.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-win.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]
..\..\out\Release\mksnapshot.exe : fatal error LNK1120: 1 unresolved externals [D:\a\node\node\tools\v8_gypfiles\mksnapshot.vcxproj]

GitHub actions logs: https://github.com/nodejs/node/runs/3489315814

/cc @nodejs/v8 I'll open a revert PR if we cannot resolve this quickly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    v8 engineIssues and PRs related to the V8 dependency.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions