-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
Closed
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.
Description
Possible data race when worker_threads
are active?
node/src/crypto/crypto_context.cc
Lines 749 to 751 in 1287530
if (root_cert_store == nullptr) { | |
root_cert_store = NewRootCertStore(); | |
} |
root_cert_store
is a static X509_STORE*
that is assigned to (and read from) without any kind of synchronization, AFAICT.
Metadata
Metadata
Assignees
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.