Description
re. test-shadow-realm-gc-module
and test-shadow-realm-gc
, I think we should just skip them. Possible solution can be, use the more reliable checkIfCollectableByCounting()
to check if the ShadowRealm instance in the main context can be collected, but I feel that would make the test invalid too (e.g. the native side can still be leaking even though the JS instances are collectable), so we might as well just skip and figure out a better way to test it later.
re. test-net-write-fully-async-hex-string
, looks like it's related to --expose-gc
again. I'd suggest that we just open an issue to track this and the shadow realm tests, and skip them for now. They are likely flaking due to incorrect assumptions in the tests broken by V8's new GC strategy, not real bugs.
Originally posted by @joyeecheung in #51362 (comment)