-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
Port/Duplicate async_hooks tests to use AsyncLocalStore #55712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
#54879 got merged? It looks like it was just closed to wait for v24. In any case, I've added the drag-agenda label. Let's discuss this in more detail in the next diagnostics working group call. (Not the one today...probably a bit short notice for that.) |
No it wasn't. Will reopen for 24 at some time. Anyhow, just noticed that I linked the wrong PR. It is about yours which was merged a while ago: #55552 That one changes internal how ALS works and relying on AsyncHooks tests is no longer applicable. |
It swaps the default for the flag, but all tests with the |
Yes, they run with both. I'm talking more about the tests which don't have the |
Ah, well if there's things which are testing ALS-related behaviour that aren't actually marked as such then there should probably be some tests specific to ALS for those scenarios. |
Add a test to verify AsyncLocalStore functionality for HTTP using a keep alive agent. AsyncLocalStore moves away from using async_hooks therefore relying on async_hooks tests alone is not longer valid. PR-URL: #58017 Refs: #55712 Refs: #13325 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add a test to verify AsyncLocalStore functionality for HTTP using a keep alive agent. AsyncLocalStore moves away from using async_hooks therefore relying on async_hooks tests alone is not longer valid. PR-URL: #58017 Refs: #55712 Refs: #13325 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
Add a test to verify AsyncLocalStore functionality for HTTP using a keep alive agent. AsyncLocalStore moves away from using async_hooks therefore relying on async_hooks tests alone is not longer valid. PR-URL: #58017 Refs: #55712 Refs: #13325 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
Short after #55552 was merged I notices that this resulted in loosing a lot test for
AsyncLocalStore
.Before
AsyncLocalStore
was based on async hooks. There are plenty of tests for async hooks which implict verified thatAsyncLocalStore
does what it is expected.But since #55552
AsyncLocalStore
and async hooks are independent.I don't think we have to dup them all, but there are some special cases at least in HTTP area (e.g. here) which might require followups.
fyi @nodejs/diagnostics
Edit 21.11.: corrected link to PR
The text was updated successfully, but these errors were encountered: