Skip to content

test-blob-slice-with-large-size is flaky #57235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aduh95 opened this issue Feb 28, 2025 · 4 comments · Fixed by #58414
Closed

test-blob-slice-with-large-size is flaky #57235

aduh95 opened this issue Feb 28, 2025 · 4 comments · Fixed by #58414
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. smartos Issues and PRs related to the SmartOS platform. windows Issues and PRs related to the Windows platform.

Comments

@aduh95
Copy link
Contributor

aduh95 commented Feb 28, 2025

Test

test-blob-slice-with-large-size

Platform

SmartOS

Console output

---
duration_ms: 290.507
exitcode: 1
severity: fail
stack: |-
  /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos23-x64/test/pummel/test-blob-slice-with-large-size.js:18
      throw e;
      ^

  RangeError: Array buffer allocation failed
      at new ArrayBuffer (<anonymous>)
      at new Uint8Array (<anonymous>)
      at new FastBuffer (node:internal/buffer:961:5)
      at createUnsafeBuffer (node:internal/buffer:1097:12)
      at allocate (node:buffer:445:10)
      at Function.allocUnsafe (node:buffer:410:10)
      at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos23-x64/test/pummel/test-blob-slice-with-large-size.js:12:22)
      at Module._compile (node:internal/modules/cjs/loader:1734:14)
      at Object..js (node:internal/modules/cjs/loader:1899:10)
      at Module.load (node:internal/modules/cjs/loader:1469:32)

  Node.js v24.0.0-pre

Build links

Additional information

It seems to reproduce quite rarely
@aduh95 aduh95 added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Feb 28, 2025
@github-actions github-actions bot added the smartos Issues and PRs related to the SmartOS platform. label Feb 28, 2025
@aduh95 aduh95 mentioned this issue Feb 28, 2025
Merged
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 28, 2025

/cc @nodejs/platform-smartos

@joyeecheung
Copy link
Member

This is now flaking many Windows tests and somehow it's relatively recent (starting from May 16 -perhaps something landed around that time made it a lot more flaky). In the latest report https://github.com/nodejs/reliability/blob/main/reports/2025-05-18.md this has failed 17 PRs out of the last 100 CI runs

@joyeecheung joyeecheung mentioned this issue May 18, 2025
Merged
@tniessen tniessen added the windows Issues and PRs related to the Windows platform. label May 21, 2025
@tniessen
Copy link
Member

In #58379, this test has failed 6 of 8 Windows CI runs and is still blocking the PR.

@tniessen tniessen mentioned this issue May 21, 2025
Merged
@joyeecheung joyeecheung mentioned this issue May 21, 2025
Merged
@joyeecheung
Copy link
Member

I think it's just the test not being written in a way that's robust enough to skip when there's not enough memory. Fix in #58414

targos pushed a commit that referenced this issue May 31, 2025
@joyeecheung @targos
test: fix missing edge case in test-blob-slice-with-large-size
53cb298 
The test only cares about whether a size outside the range
of the 32-bit signed integers works with Blob.prototype.slice().
If it fails due to allocation failure when the system
does not have enough memory, the test should just be skipped.
The test previously only skipped the test when the allocation
failure happens during allocation of the buffer source, but
it could also happen during Blob.prototype.slice().

PR-URL: #58414
Fixes: #57235
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. smartos Issues and PRs related to the SmartOS platform. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix missing edge case in test-blob-slice-with-large-size joyeecheung/node
3 participants
@tniessen @joyeecheung @aduh95