Skip to content

test: replace common.fixturesDir with fixtures.fixturesDir #15806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisajimenez wants to merge 1 commit into from
Closed

test: replace common.fixturesDir with fixtures.fixturesDir #15806

chrisajimenez wants to merge 1 commit into from

Conversation

@chrisajimenez
Copy link
Contributor

@chrisajimenez chrisajimenez commented Oct 6, 2017 •
edited
Loading

Replacing the usage of common.fixturesDir with fixtures.fixturesDir in test/parallel/test-fs-whatwg-url.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@Trott
Copy link
Member

Trott commented Oct 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10468/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 11, 2017
@chrisajimenez @Trott
test: replace common.fixturesDir with fixtures
6af8896 
PR-URL: nodejs#15806
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 11, 2017

Landed in 6af8896.
Thanks for the contribution! 🎉

@Trott Trott closed this Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@chrisajimenez @addaleax
test: replace common.fixturesDir with fixtures
eb262be 
PR-URL: nodejs/node#15806
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@chrisajimenez @targos
test: replace common.fixturesDir with fixtures
228940d 
PR-URL: #15806
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+1 more reviewer

@rmg rmg rmg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@chrisajimenez @Trott @rmg @jasnell @benjamingr @lpinca @gireeshpunathil @mscdex @MylesBorins @nodejs-github-bot