-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
build,win: enable lint option to run "standalone" #16176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support to run the linter without running any other targets. This commit also makes the lint task a little more quite and more inline with the output on other operating systems. Below is an example of running (with a lint error to show that it is not so quite that errors are hidden): C:\Users\danbev\working\node>vcbuild.bat lint running lint-cpp 'src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h' src\env.h:24: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 "C:\Python27\python.exe" tools/check-imports.py running lint-js The help message now looks like: C:\Users\danbev\working\node>vcbuild.bat /? vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/ test-inspector/test-internet/test-pummel/test-simple/test-message/ test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/ test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module] Examples: vcbuild.bat : builds release build vcbuild.bat debug : builds debug build vcbuild.bat release msi : builds release build and MSI installer package vcbuild.bat test : builds debug build and runs tests vcbuild.bat build-release : builds the release distribution as used by nodejs.org vcbuild.bat enable-vtune : builds nodejs with Intel VTune profiling support to profile JavaScript vcbuild.bat link-module my_module.js : bundles my_module as built-in module vcbuild.bat lint : runs the C++ and JavaScript linter
jasnell
approved these changes
Oct 13, 2017
gireeshpunathil
approved these changes
Oct 16, 2017
Member
Contributor
Author
test/windows-fanned unstable looks unrelatednot ok 470 inspector/test-bindings # TODO : Fix flaky test
---
duration_ms: 0.250
severity: flaky
stack: |-
Expecting warning to be emitted
(node:6744) Error: We expect this
c:\workspace\node-test-binary-windows\test\common\index.js:793
(err) => process.nextTick(() => { throw err; }));
^
AssertionError [ERR_ASSERTION]: [ 'Iteration 1 variable: i expected: 1 actual: 0',
'Iteration 2 variable: i expected: 2 actual: 1',
'Iteration 2 variable: a deepStrictEqual []
at testSampleDebugSession (c:\workspace\node-test-binary-windows\test\inspector\test-bindings.js:104:10)
at doTests (c:\workspace\node-test-binary-windows\test\inspector\test-bindings.js:131:3)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
at Function.Module.runMain (module.js:642:11)
at startup (bootstrap_node.js:187:16)
at bootstrap_node.js:605:3
...
not ok 471 inspector/test-debug-end # TODO : Fix flaky test
---
duration_ms: 0.640
severity: flaky
stack: |-
Test there's no crash stopping server that was not started
Test there's no crash stopping server without connecting
[err] Debugger listening on ws://127.0.0.1:63963/9a114a23-f790-487e-945f-176960414cdb
[err] For help see https://nodejs.org/en/docs/inspector
[err]
Test there's no crash stopping server after connecting
[test] Connecting to a child Node process
[test] Testing /json/list
[err] Debugger listening on ws://127.0.0.1:63964/aa4f597e-619b-4d17-b144-e62d80daf6e0
[err] For help see https://nodejs.org/en/docs/inspector
[err]
[err] Debugger attached.
[err] Debugger listening on ws://127.0.0.1:63967/70447c1e-6b5e-400a-858f-fca441a45ef0
[err] For help see https://nodejs.org/en/docs/inspector
[err]
{ AssertionError [ERR_ASSERTION]: 42 === 3221225477
at testSessionNoCrash (c:\workspace\node-test-binary-windows\test\inspector\test-debug-end.js:35:3)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
generatedMessage: true,
name: 'AssertionError [ERR_ASSERTION]',
code: 'ERR_ASSERTION',
actual: 42,
expected: 3221225477,
operator: '===' }
1 |
danbev
added a commit
to danbev/node
that referenced
this pull request
Oct 17, 2017
This commit adds support to run the linter without running any other targets. This commit also makes the lint task a little more quite and more inline with the output on other operating systems. Below is an example of running (with a lint error to show that it is not so quite that errors are hidden): C:\Users\danbev\working\node>vcbuild.bat lint running lint-cpp 'src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h' src\env.h:24: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 "C:\Python27\python.exe" tools/check-imports.py running lint-js The help message now looks like: C:\Users\danbev\working\node>vcbuild.bat /? vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/ test-inspector/test-internet/test-pummel/test-simple/test-message/ test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/ test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module] Examples: vcbuild.bat : builds release build vcbuild.bat debug : builds debug build vcbuild.bat release msi : builds release build and MSI installer package vcbuild.bat test : builds debug build and runs tests vcbuild.bat build-release : builds the release distribution as used by nodejs.org vcbuild.bat enable-vtune : builds nodejs with Intel VTune profiling support to profile JavaScript vcbuild.bat link-module my_module.js : bundles my_module as built-in module vcbuild.bat lint : runs the C++ and JavaScript linter PR-URL: nodejs#16176 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Contributor
Author
|
Landed in d78086b |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
This commit adds support to run the linter without running any other targets. This commit also makes the lint task a little more quite and more inline with the output on other operating systems. Below is an example of running (with a lint error to show that it is not so quite that errors are hidden): C:\Users\danbev\working\node>vcbuild.bat lint running lint-cpp 'src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h' src\env.h:24: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 "C:\Python27\python.exe" tools/check-imports.py running lint-js The help message now looks like: C:\Users\danbev\working\node>vcbuild.bat /? vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/ test-inspector/test-internet/test-pummel/test-simple/test-message/ test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/ test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module] Examples: vcbuild.bat : builds release build vcbuild.bat debug : builds debug build vcbuild.bat release msi : builds release build and MSI installer package vcbuild.bat test : builds debug build and runs tests vcbuild.bat build-release : builds the release distribution as used by nodejs.org vcbuild.bat enable-vtune : builds nodejs with Intel VTune profiling support to profile JavaScript vcbuild.bat link-module my_module.js : bundles my_module as built-in module vcbuild.bat lint : runs the C++ and JavaScript linter PR-URL: #16176 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
This commit adds support to run the linter without running any other targets. This commit also makes the lint task a little more quite and more inline with the output on other operating systems. Below is an example of running (with a lint error to show that it is not so quite that errors are hidden): C:\Users\danbev\working\node>vcbuild.bat lint running lint-cpp 'src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h' src\env.h:24: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 "C:\Python27\python.exe" tools/check-imports.py running lint-js The help message now looks like: C:\Users\danbev\working\node>vcbuild.bat /? vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/ test-inspector/test-internet/test-pummel/test-simple/test-message/ test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/ test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module] Examples: vcbuild.bat : builds release build vcbuild.bat debug : builds debug build vcbuild.bat release msi : builds release build and MSI installer package vcbuild.bat test : builds debug build and runs tests vcbuild.bat build-release : builds the release distribution as used by nodejs.org vcbuild.bat enable-vtune : builds nodejs with Intel VTune profiling support to profile JavaScript vcbuild.bat link-module my_module.js : bundles my_module as built-in module vcbuild.bat lint : runs the C++ and JavaScript linter PR-URL: nodejs/node#16176 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Contributor
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to run the linter without running any other
targets. This commit also makes the lint task a little more quite and
more inline with the output on other operating systems.
Below is an example of running (with a lint error to show that it is not
so quite that errors are hidden):
The help message now looks like:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build, windows