doc: update test/inspector reference #16277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
joyeecheung
reviewed
Oct 18, 2017
doc/api/inspector.md
Outdated
Member
There was a problem hiding this comment.
Maybe we can just use a fake name here? Something like // [ '/the/file/that/has/the/breakpoint.js:11:0' ] ?
Contributor
Author
|
updated @joyeecheung |
jasnell
approved these changes
Oct 18, 2017
joyeecheung
approved these changes
Oct 18, 2017
Member
|
This shouldn't need to wait the 48 hours to land |
jasnell
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #16277 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Member
|
Landed in 1446db0 |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #16277 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#16277 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16277 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated reference to new path and line numbers, but thinking this line should just be removed, not sure how helpful it is.
Checklist
Affected core subsystem(s)
doc