http2: fix graceful session close#30854
Closed
lundibundi wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThis is tied to
started with #20630, then #19852 and #20772.
The description is in the commits. This should fix our ECONNRESET during graceful close bugs in http2 tests.
Basically now we use
socket.end()upon graceful close.Also, I understand that now there is no way to actually
destroythe socket if needed. If the second commit is accepted I planned to 'overload'session.destroy()to actually destroy the socket if we already initiated graceful close but want to destroy the session without waiting for FIN./cc @addaleax @jasnell @apapirovski @nodejs/http2