-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
Feature/dns caa #35466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Feature/dns caa #35466
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b5de9b4
Backport CAA parsing from c-ares
lxdicted 08d2e88
Added support for resolving DNS CAA records
lxdicted 5a08eaa
Fixed a typo
lxdicted 9218871
Whitespace changes
lxdicted eaafda6
Added missing types
lxdicted 71f350b
Partially reverted change
lxdicted bb9a6ec
Documentation update
lxdicted 87db47d
MacOS compile fix
lxdicted 5e52515
Fixed documentation version
lxdicted d1e115f
Allow parsing of CAA records when queying ANY
lxdicted 1e18c47
Documentation update
lxdicted File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,209 @@ | ||
|
|
||
| /* Copyright 2020 by <[email protected]> | ||
| * | ||
| * Permission to use, copy, modify, and distribute this | ||
| * software and its documentation for any purpose and without | ||
| * fee is hereby granted, provided that the above copyright | ||
| * notice appear in all copies and that both that copyright | ||
| * notice and this permission notice appear in supporting | ||
| * documentation, and that the name of M.I.T. not be used in | ||
| * advertising or publicity pertaining to distribution of the | ||
| * software without specific, written prior permission. | ||
| * M.I.T. makes no representations about the suitability of | ||
| * this software for any purpose. It is provided "as is" | ||
| * without express or implied warranty. | ||
| */ | ||
|
|
||
| #include "ares_setup.h" | ||
|
|
||
| #ifdef HAVE_NETINET_IN_H | ||
| # include <netinet/in.h> | ||
| #endif | ||
| #ifdef HAVE_NETDB_H | ||
| # include <netdb.h> | ||
| #endif | ||
| #ifdef HAVE_ARPA_INET_H | ||
| # include <arpa/inet.h> | ||
| #endif | ||
| #ifdef HAVE_ARPA_NAMESER_H | ||
| # include <arpa/nameser.h> | ||
| #else | ||
| # include "nameser.h" | ||
| #endif | ||
| #ifdef HAVE_ARPA_NAMESER_COMPAT_H | ||
| # include <arpa/nameser_compat.h> | ||
| #endif | ||
|
|
||
| #ifdef HAVE_STRINGS_H | ||
| # include <strings.h> | ||
| #endif | ||
|
|
||
| #include "ares.h" | ||
| #include "ares_dns.h" | ||
| #include "ares_data.h" | ||
| #include "ares_private.h" | ||
|
|
||
| #ifndef T_CAA | ||
| # define T_CAA 257 /* Certification Authority Authorization */ | ||
| #endif | ||
|
|
||
| int | ||
| ares_parse_caa_reply (const unsigned char *abuf, int alen, | ||
| struct ares_caa_reply **caa_out) | ||
| { | ||
| unsigned int qdcount, ancount, i; | ||
| const unsigned char *aptr; | ||
| const unsigned char *strptr; | ||
| int status, rr_type, rr_class, rr_len; | ||
| long len; | ||
| char *hostname = NULL, *rr_name = NULL; | ||
| struct ares_caa_reply *caa_head = NULL; | ||
| struct ares_caa_reply *caa_last = NULL; | ||
| struct ares_caa_reply *caa_curr; | ||
|
|
||
| /* Set *caa_out to NULL for all failure cases. */ | ||
| *caa_out = NULL; | ||
|
|
||
| /* Give up if abuf doesn't have room for a header. */ | ||
| if (alen < HFIXEDSZ) | ||
| return ARES_EBADRESP; | ||
|
|
||
| /* Fetch the question and answer count from the header. */ | ||
| qdcount = DNS_HEADER_QDCOUNT (abuf); | ||
| ancount = DNS_HEADER_ANCOUNT (abuf); | ||
| if (qdcount != 1) | ||
| return ARES_EBADRESP; | ||
| if (ancount == 0) | ||
| return ARES_ENODATA; | ||
|
|
||
| /* Expand the name from the question, and skip past the question. */ | ||
| aptr = abuf + HFIXEDSZ; | ||
| status = ares_expand_name (aptr, abuf, alen, &hostname, &len); | ||
| if (status != ARES_SUCCESS) | ||
| return status; | ||
|
|
||
| if (aptr + len + QFIXEDSZ > abuf + alen) | ||
| { | ||
| ares_free (hostname); | ||
| return ARES_EBADRESP; | ||
| } | ||
| aptr += len + QFIXEDSZ; | ||
|
|
||
| /* Examine each answer resource record (RR) in turn. */ | ||
| for (i = 0; i < ancount; i++) | ||
| { | ||
| /* Decode the RR up to the data field. */ | ||
| status = ares_expand_name (aptr, abuf, alen, &rr_name, &len); | ||
| if (status != ARES_SUCCESS) | ||
| { | ||
| break; | ||
| } | ||
| aptr += len; | ||
| if (aptr + RRFIXEDSZ > abuf + alen) | ||
| { | ||
| status = ARES_EBADRESP; | ||
| break; | ||
| } | ||
| rr_type = DNS_RR_TYPE (aptr); | ||
| rr_class = DNS_RR_CLASS (aptr); | ||
| rr_len = DNS_RR_LEN (aptr); | ||
| aptr += RRFIXEDSZ; | ||
| if (aptr + rr_len > abuf + alen) | ||
| { | ||
| status = ARES_EBADRESP; | ||
| break; | ||
| } | ||
|
|
||
| /* Check if we are really looking at a CAA record */ | ||
| if ((rr_class == C_IN || rr_class == C_CHAOS) && rr_type == T_CAA) | ||
| { | ||
| strptr = aptr; | ||
|
|
||
| /* Allocate storage for this CAA answer appending it to the list */ | ||
| caa_curr = ares_malloc_data(ARES_DATATYPE_CAA_REPLY); | ||
| if (!caa_curr) | ||
| { | ||
| status = ARES_ENOMEM; | ||
| break; | ||
| } | ||
| if (caa_last) | ||
| { | ||
| caa_last->next = caa_curr; | ||
| } | ||
| else | ||
| { | ||
| caa_head = caa_curr; | ||
| } | ||
| caa_last = caa_curr; | ||
| if (rr_len < 2) | ||
| { | ||
| status = ARES_EBADRESP; | ||
| break; | ||
| } | ||
| caa_curr->critical = (int)*strptr++; | ||
| caa_curr->plength = (int)*strptr++; | ||
| if (caa_curr->plength <= 0 || (int)caa_curr->plength >= rr_len - 2) | ||
| { | ||
| status = ARES_EBADRESP; | ||
| break; | ||
| } | ||
| caa_curr->property = ares_malloc (caa_curr->plength + 1/* Including null byte */); | ||
| if (caa_curr->property == NULL) | ||
| { | ||
| status = ARES_ENOMEM; | ||
| break; | ||
| } | ||
| memcpy ((char *) caa_curr->property, strptr, caa_curr->plength); | ||
| /* Make sure we NULL-terminate */ | ||
| caa_curr->property[caa_curr->plength] = 0; | ||
| strptr += caa_curr->plength; | ||
|
|
||
| caa_curr->length = rr_len - caa_curr->plength - 2; | ||
| if (caa_curr->length <= 0) | ||
| { | ||
| status = ARES_EBADRESP; | ||
| break; | ||
| } | ||
| caa_curr->value = ares_malloc (caa_curr->length + 1/* Including null byte */); | ||
| if (caa_curr->value == NULL) | ||
| { | ||
| status = ARES_ENOMEM; | ||
| break; | ||
| } | ||
| memcpy ((char *) caa_curr->value, strptr, caa_curr->length); | ||
| /* Make sure we NULL-terminate */ | ||
| caa_curr->value[caa_curr->length] = 0; | ||
| } | ||
|
|
||
| /* Propagate any failures */ | ||
| if (status != ARES_SUCCESS) | ||
| { | ||
| break; | ||
| } | ||
|
|
||
| /* Don't lose memory in the next iteration */ | ||
| ares_free (rr_name); | ||
| rr_name = NULL; | ||
|
|
||
| /* Move on to the next record */ | ||
| aptr += rr_len; | ||
| } | ||
|
|
||
| if (hostname) | ||
| ares_free (hostname); | ||
| if (rr_name) | ||
| ares_free (rr_name); | ||
|
|
||
| /* clean up on error */ | ||
| if (status != ARES_SUCCESS) | ||
| { | ||
| if (caa_head) | ||
| ares_free_data (caa_head); | ||
| return status; | ||
| } | ||
|
|
||
| /* everything looks fine, return the data */ | ||
| *caa_out = caa_head; | ||
|
|
||
| return ARES_SUCCESS; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.