tools: add execution permission to uvwasi script #47600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there context on why this is needed? 👀 |
we were encountering permission error |
|
@mertcanaltin Can you write a descriptive description to your PR and the command you executed to fix the issue, and provide a link to the original issue? |
mertcanaltin
force-pushed
the
dev-1
branch
2 times, most recently
from
a9c8b8b to
bbbb9f4
Compare
mertcanaltin
changed the title
anonrig
approved these changes
Apr 17, 2023
|
cc @nodejs/actions |
anonrig
added
the
author ready
|
Refs: #47597 |
targos
approved these changes
Apr 18, 2023
lpinca
approved these changes
Apr 18, 2023
anonrig
added
the
commit-queue
marco-ippolito
approved these changes
Apr 19, 2023
tniessen
approved these changes
Apr 19, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
nodejs-github-bot
added
commit-queue-failed
This comment was marked as off-topic.
This comment was marked as off-topic.
tniessen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f509f10 |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47600 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47600 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47600 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking to anonrig, I realized that it was a permission error. I typed chmod +x and ran it and sent it
issue
cc @anonrig for keeping him in the loop