esm: unflag import.meta.resolve#49028
Merged
nodejs-github-bot merged 8 commits intonodejs:mainfrom Aug 13, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unflags
import.meta.resolvemaking the secondparentURLargument still gated behind the same--experimental-import-meta-resolveflag so that existing users would retain backwards compatibility, while the default behaviour becomes standards compliant.If we can combine this approach with supporting
file:///URLs infetch, that would be a powerful new approach for cross-platform asset loading -await (await fetch(import.meta.resolve('./asset.bin'))).arrayBuffer()which hopefully in turn bundlers should also be able to support better too.//cc @nodejs/modules