-
-
Notifications
You must be signed in to change notification settings - Fork 32k
lib: add --no-experimental-global-navigator
CLI flag
#50562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -391,6 +391,11 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { | |||||||||||
&EnvironmentOptions::experimental_global_customevent, | ||||||||||||
kAllowedInEnvvar, | ||||||||||||
true); | ||||||||||||
AddOption("--experimental-global-navigator", | ||||||||||||
"expose experimental Navigator API on the global scope", | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the reason for adding this noop? It doesn't seem to be used, or mentioned in anywhere. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not a no-op, it's the flag being added; see the above one for an another example of such flag: Lines 389 to 393 in 3860002
That being said, it looks like I forgot to switch the default value to true |
||||||||||||
&EnvironmentOptions::experimental_global_navigator, | ||||||||||||
kAllowedInEnvvar, | ||||||||||||
true); | ||||||||||||
AddOption("--experimental-global-webcrypto", | ||||||||||||
"expose experimental Web Crypto API on the global scope", | ||||||||||||
&EnvironmentOptions::experimental_global_web_crypto, | ||||||||||||
|
Uh oh!
There was an error while loading. Please reload this page.