-
-
Notifications
You must be signed in to change notification settings - Fork 32k
benchmark: add misc/startup-cli-version benchmark #50684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
'use strict'; | ||
const common = require('../common.js'); | ||
const { spawnSync } = require('child_process'); | ||
const path = require('path'); | ||
|
||
// This benchmarks the startup of various CLI tools that are already | ||
// checked into the source code. We use --version because the output | ||
// tends to be minimal and fewer operations are done to generate | ||
// these so that the startup cost is still dominated by a more | ||
// indispensible part of the CLI. | ||
const bench = common.createBenchmark(main, { | ||
cli: [ | ||
'tools/node_modules/eslint/bin/eslint.js', | ||
'deps/npm/bin/npm-cli.js', | ||
'deps/corepack/dist/corepack.js', | ||
], | ||
count: [30], | ||
}); | ||
|
||
function spawnProcess(cli, bench, state) { | ||
const cmd = process.execPath || process.argv[0]; | ||
while (state.finished < state.count) { | ||
const child = spawnSync(cmd, [cli, '--version'], { | ||
env: { npm_config_loglevel: 'silent', ...process.env }, | ||
}); | ||
// Log some information for debugging if it fails, which it shouldn't. | ||
if (child.status !== 0) { | ||
console.log('---- STDOUT ----'); | ||
console.log(child.stdout.toString()); | ||
console.log('---- STDERR ----'); | ||
console.log(child.stderr.toString()); | ||
joyeecheung marked this conversation as resolved.
Show resolved
Hide resolved
|
||
throw new Error(`Child process stopped with exit code ${child.status}`); | ||
} | ||
state.finished++; | ||
if (state.finished === 0) { | ||
// Finished warmup. | ||
bench.start(); | ||
} | ||
|
||
if (state.finished === state.count) { | ||
bench.end(state.count); | ||
} | ||
} | ||
} | ||
|
||
function main({ count, cli }) { | ||
cli = path.resolve(__dirname, '../../', cli); | ||
const warmup = 3; | ||
const state = { count, finished: -warmup }; | ||
spawnProcess(cli, bench, state); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.