test: remove unneeded common.indirectInstanceOf()#5149
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove unneeded common.indirectInstanceOf()#5149Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
Author
Member
Author
|
/cc @nodejs/testing I guess |
Member
|
LGTM. IIRC, |
Member
Author
|
Went to land this one, but there was a conflict. Resolved the conflict but want to run CI one more time just to make sure I didn't mess it up: https://ci.nodejs.org/job/node-test-pull-request/1626/ |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 10, 2016
PR-URL: nodejs#5149 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Member
Author
|
Landed in 2571386 |
rvagg
pushed a commit
that referenced
this pull request
Feb 15, 2016
PR-URL: #5149 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #5149 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #5149 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #5149 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.