test: fix test runner arg regression #5446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append --node-args to existing list, don't overwrite arg list.
This was referenced Feb 26, 2016
|
LGTM. CI run above is green so will land |
mhdawson
pushed a commit
that referenced
this pull request
Feb 26, 2016
Append --node-args to existing list, don't overwrite arg list. Fixes: #5442 PR-URL: #5446 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-by: Michael Dawson <[email protected]>
|
Landed as c98d159 |
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
Append --node-args to existing list, don't overwrite arg list. Fixes: #5442 PR-URL: #5446 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-by: Michael Dawson <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
Append --node-args to existing list, don't overwrite arg list. Fixes: #5442 PR-URL: #5446 Reviewed-By: Ben Noorhduis <[email protected]> Reviewed-by: Michael Dawson <[email protected]>
|
marking this and it's dependent PRs as don't land on v4.x... we can revisit that later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected core subsystem(s)
test
Description of change
In #5376 I introduced the "--node-args" facility to test.py by overwriting the test configuration additional argument list. Instead, I should have simply appended to the list to preserve the existing arguments. This PR fixes the regression introduced and reported in #5442.
After this PR the test runner will append --node-args to the existing argument list (if it is present), instead of simply overwriting it.