Skip to content

test: update wpt test for webmessaging/broadcastchannel #55205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/fixtures/wpt/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Last update:
- wasm/webapi: https://github.com/web-platform-tests/wpt/tree/fd1b23eeaa/wasm/webapi
- WebCryptoAPI: https://github.com/web-platform-tests/wpt/tree/203d2ac459/WebCryptoAPI
- webidl/ecmascript-binding/es-exceptions: https://github.com/web-platform-tests/wpt/tree/a370aad338/webidl/ecmascript-binding/es-exceptions
- webmessaging/broadcastchannel: https://github.com/web-platform-tests/wpt/tree/e97fac4791/webmessaging/broadcastchannel
- webmessaging/broadcastchannel: https://github.com/web-platform-tests/wpt/tree/6495c91853/webmessaging/broadcastchannel
- webstorage: https://github.com/web-platform-tests/wpt/tree/9dafa89214/webstorage

[Web Platform Tests]: https://github.com/web-platform-tests/wpt
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/wpt/versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"path": "webidl/ecmascript-binding/es-exceptions"
},
"webmessaging/broadcastchannel": {
"commit": "e97fac4791931fb7455ba3fad759d362c7108b09",
"commit": "6495c91853a3cf028a401cf4d228fc0b6a5465e4",
"path": "webmessaging/broadcastchannel"
},
"webstorage": {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
features:
- name: broadcast-channel
files: "**"
8 changes: 8 additions & 0 deletions test/fixtures/wpt/webmessaging/broadcastchannel/basics.any.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
test(function() {
assert_throws_js(
TypeError,
() => BroadcastChannel(""),
"Calling BroadcastChannel constructor without 'new' must throw"
);
}, "BroadcastChannel constructor called as normal function");

async_test(t => {
let c1 = new BroadcastChannel('eventType');
let c2 = new BroadcastChannel('eventType');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@
// Since the worker has closed, it's not expected that the
// BroadcastChannel will receive messages (there's a separate test for
// that), so just indicate directly that it's ready to test receiving
// a message from the parent despite the possibility of a race condition.
// a message from the parent dispite the possibility of a race condition.
postMessage('ready');
}
});
Expand Down
Loading