-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
worker: add eval ts input #56394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:eval-ts-in-workers
Jan 3, 2025
Merged
worker: add eval ts input #56394
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
'use strict'; | ||
require('../common'); | ||
const assert = require('assert'); | ||
const { Worker } = require('worker_threads'); | ||
const { test } = require('node:test'); | ||
const { once } = require('events'); | ||
|
||
const esmHelloWorld = ` | ||
import worker from 'worker_threads'; | ||
const foo: string = 'Hello, World!'; | ||
worker.parentPort.postMessage(foo); | ||
`; | ||
|
||
const cjsHelloWorld = ` | ||
const { parentPort } = require('worker_threads'); | ||
const foo: string = 'Hello, World!'; | ||
parentPort.postMessage(foo); | ||
`; | ||
|
||
const disableTypeScriptWarningFlag = '--disable-warning=ExperimentalWarning'; | ||
|
||
test('Worker eval module typescript without input-type', async () => { | ||
const w = new Worker(esmHelloWorld, { eval: true, execArgv: [disableTypeScriptWarningFlag] }); | ||
assert.deepStrictEqual(await once(w, 'message'), ['Hello, World!']); | ||
}); | ||
|
||
test('Worker eval module typescript with --input-type=module-typescript', async () => { | ||
const w = new Worker(esmHelloWorld, { eval: true, execArgv: ['--input-type=module-typescript', | ||
disableTypeScriptWarningFlag] }); | ||
assert.deepStrictEqual(await once(w, 'message'), ['Hello, World!']); | ||
}); | ||
|
||
test('Worker eval module typescript with --input-type=commonjs-typescript', async () => { | ||
const w = new Worker(esmHelloWorld, { eval: true, execArgv: ['--input-type=commonjs-typescript', | ||
disableTypeScriptWarningFlag] }); | ||
|
||
const [err] = await once(w, 'error'); | ||
assert.strictEqual(err.name, 'SyntaxError'); | ||
assert.match(err.message, /Cannot use import statement outside a module/); | ||
}); | ||
|
||
test('Worker eval module typescript with --input-type=module', async () => { | ||
const w = new Worker(esmHelloWorld, { eval: true, execArgv: ['--input-type=module', | ||
disableTypeScriptWarningFlag] }); | ||
const [err] = await once(w, 'error'); | ||
assert.strictEqual(err.name, 'SyntaxError'); | ||
assert.match(err.message, /Missing initializer in const declaration/); | ||
}); | ||
|
||
test('Worker eval commonjs typescript without input-type', async () => { | ||
const w = new Worker(cjsHelloWorld, { eval: true, execArgv: [disableTypeScriptWarningFlag] }); | ||
assert.deepStrictEqual(await once(w, 'message'), ['Hello, World!']); | ||
}); | ||
|
||
test('Worker eval commonjs typescript with --input-type=commonjs-typescript', async () => { | ||
const w = new Worker(cjsHelloWorld, { eval: true, execArgv: ['--input-type=commonjs-typescript', | ||
disableTypeScriptWarningFlag] }); | ||
assert.deepStrictEqual(await once(w, 'message'), ['Hello, World!']); | ||
}); | ||
|
||
test('Worker eval commonjs typescript with --input-type=module-typescript', async () => { | ||
const w = new Worker(cjsHelloWorld, { eval: true, execArgv: ['--input-type=module-typescript', | ||
disableTypeScriptWarningFlag] }); | ||
const [err] = await once(w, 'error'); | ||
assert.strictEqual(err.name, 'ReferenceError'); | ||
assert.match(err.message, /require is not defined in ES module scope, you can use import instead/); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.