Skip to content

doc: clarify DEP0194 scope #58504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
+16 −5
Merged

doc: clarify DEP0194 scope #58504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3935,7 +3935,7 @@ The `node:_stream_duplex`, `node:_stream_passthrough`, `node:_stream_readable`,
`node:_stream_wrap` and `node:_stream_writable` modules are deprecated as they should be considered
an internal nodejs implementation rather than a public facing API, use `node:stream` instead.

### DEP0194: `require('node:http2').Http2Stream.priority`
### DEP0194: HTTP/2 priority signaling

<!-- YAML
changes:
Expand Down
19 changes: 15 additions & 4 deletions doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,6 +1071,11 @@

<!-- YAML
added: v8.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/58313

Check warning on line 1076 in doc/api/http2.md

View workflow job for this annotation

GitHub Actions / lint-pr-url 

pr-url doesn't match the URL of the current PR.
description: Following the deprecation of priority signaling as of RFC 1993,
`weight` option is deprecated.
-->

* `headers` {HTTP/2 Headers Object} | {Array}
Expand All @@ -1087,7 +1092,8 @@
created stream is dependent on.
* `weight` {number} Specifies the relative dependency of a stream in relation
to other streams with the same `parent`. The value is a number between `1`
and `256` (inclusive).
and `256` (inclusive). This has been **deprecated** in [RFC 9113][], and
support for it will be removed in future versions of Node.js.
* `waitForTrailers` {boolean} When `true`, the `Http2Stream` will emit the
`'wantTrailers'` event after the final `DATA` frame has been sent.
* `signal` {AbortSignal} An AbortSignal that may be used to abort an ongoing
Expand Down Expand Up @@ -1460,6 +1466,9 @@
deprecated: REPLACEME
-->

> Stability: 0 - Deprecated: support for priority signaling has been deprecated
> in the [RFC 9113][] and is no longer supported in Node.js.

* `options` {Object}
* `exclusive` {boolean} When `true` and `parent` identifies a parent Stream,
this stream is made the sole direct dependency of the parent, with
Expand All @@ -1475,9 +1484,6 @@

Updates the priority for this `Http2Stream` instance.

The support for priority signaling has been deprecated in the [RFC 9113][], and
will be removed in future versions of Node.js.

#### `http2stream.rstCode`

<!-- YAML
Expand Down Expand Up @@ -1572,6 +1578,11 @@

<!-- YAML
added: v8.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/58313

Check warning on line 1583 in doc/api/http2.md

View workflow job for this annotation

GitHub Actions / lint-pr-url 

pr-url doesn't match the URL of the current PR.
description: Following the deprecation of priority signaling as of RFC 1993,
`weight` and `sumDependencyWeight` options are deprecated.
-->

Provides miscellaneous information about the current state of the
Expand Down
Loading