Skip to content

test: rewrite test-child-process-spawn-args #58546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions test/parallel/test-child-process-spawn-args.js

This file was deleted.

50 changes: 50 additions & 0 deletions test/parallel/test-child-process-spawn-args.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
// This test confirms that `undefined`, `null`, and `[]`
// can be used as a placeholder for the second argument (`args`) of `spawn()`.
// Previously, there was a bug where using `undefined` for the second argument
// caused the third argument (`options`) to be ignored.
// See https://github.com/nodejs/node/issues/24912.

import * as common from '../common/index.mjs';
import tmpdir from '../common/tmpdir.js';

import assert from 'node:assert';
import { spawn } from 'node:child_process';
import { once } from 'node:events';

tmpdir.refresh();

const command = common.isWindows ? 'cd' : 'pwd';
const options = { cwd: tmpdir.path };

if (common.isWindows) {
// This test is not the case for Windows based systems
// unless the `shell` options equals to `true`
options.shell = true;
}

const testCases = [
undefined,
null,
[],
];

const expectedResult = new Set([tmpdir.path.trim().toLowerCase()]);

const actualResults = new Set();
Comment on lines +31 to +33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
const expectedResult = new Set([tmpdir.path.trim().toLowerCase()]);
const actualResults = new Set();
const expectedResults = new Set([tmpdir.path.trim().toLowerCase()]);
const actualResults = new Set();


for (const testCase of testCases) {
const subprocess = spawn(command, testCase, options);

let accumulatedData = '';

subprocess.stdout.setEncoding('utf8');
subprocess.stdout.on('data', common.mustCall((data) => {
accumulatedData += data;
}));

await once(subprocess.stdout, 'end');

actualResults.add(accumulatedData.trim().toLowerCase());
}

assert.deepStrictEqual(actualResults, expectedResult);
Loading