-
-
Notifications
You must be signed in to change notification settings - Fork 32k
lib: validate AbortSignal.timeout delay per its WebIDL definition #58648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
himself65
wants to merge
4
commits into
nodejs:main
Choose a base branch
from
himself65:himself65/2025/06/09/allow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @panva |
cc @nodejs/timers |
himself65
commented
Jun 9, 2025
0.1, | ||
0.5, | ||
1, | ||
1.0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe should add 2^32 + 1 as a test case
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58648 +/- ##
==========================================
- Coverage 90.16% 90.14% -0.03%
==========================================
Files 636 636
Lines 187891 187889 -2
Branches 36881 36877 -4
==========================================
- Hits 169409 169369 -40
- Misses 11242 11285 +43
+ Partials 7240 7235 -5
🚀 New features to boost your workflow:
|
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/15542291850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-ci
PRs that need a full CI run.
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
timers
Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
web-standards
Issues and PRs related to Web APIs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divided from #58594, this PR changes
Timeout
class to support unsigned long long asafter
parameter