Skip to content

lib: validate AbortSignal.timeout delay per its WebIDL definition #58648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

himself65
Copy link
Member

Divided from #58594, this PR changes Timeout class to support unsigned long long as after parameter

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jun 9, 2025
@himself65
Copy link
Member Author

/cc @panva

@panva
Copy link
Member

panva commented Jun 9, 2025

cc @nodejs/timers

@himself65 himself65 marked this pull request as ready for review June 9, 2025 16:06
0.1,
0.5,
1,
1.0,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe should add 2^32 + 1 as a test case

@panva panva added the web-standards Issues and PRs related to Web APIs label Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (2eeb65f) to head (ec64dbb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58648      +/-   ##
==========================================
- Coverage   90.16%   90.14%   -0.03%     
==========================================
  Files         636      636              
  Lines      187891   187889       -2     
  Branches    36881    36877       -4     
==========================================
- Hits       169409   169369      -40     
- Misses      11242    11285      +43     
+ Partials     7240     7235       -5     
Files with missing lines Coverage Δ
lib/internal/abort_controller.js 98.27% <100.00%> (+<0.01%) ⬆️
lib/internal/timers.js 99.59% <100.00%> (+<0.01%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@himself65
Copy link
Member Author

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 9, 2025
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/15542291850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. web-standards Issues and PRs related to Web APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants