Skip to content

lib: fix getTypeScriptParsingMode jsdoc #58681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShenHongFei
Copy link
Contributor

@ShenHongFei ShenHongFei commented Jun 11, 2025

fix type in getTypeScriptParsingMode's jsdoc: @type {string} should be @type {() => TypeScriptMode}

@marco-ippolito

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (5457443) to head (f89c869).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58681      +/-   ##
==========================================
+ Coverage   90.03%   90.16%   +0.12%     
==========================================
  Files         635      637       +2     
  Lines      187688   188123     +435     
  Branches    36761    36908     +147     
==========================================
+ Hits       168991   169621     +630     
+ Misses      11499    11242     -257     
- Partials     7198     7260      +62     
Files with missing lines Coverage Δ
lib/internal/modules/typescript.js 97.47% <100.00%> (ø)

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2025
@nodejs-github-bot
Copy link
Collaborator

@ShenHongFei
Copy link
Contributor Author

This test failed, but it seems to have nothing to do with my changes. Can someone help me take a look? What else do I need to do?

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/34833/RUN_SUBSET=3,nodes=win11-COMPILED_BY-vs2022_clang/

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants