-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
lib: fix getTypeScriptParsingMode
jsdoc
#58681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShenHongFei
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
ShenHongFei:fix-jsdoc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58681 +/- ##
==========================================
+ Coverage 90.03% 90.16% +0.12%
==========================================
Files 635 637 +2
Lines 187688 188123 +435
Branches 36761 36908 +147
==========================================
+ Hits 168991 169621 +630
+ Misses 11499 11242 -257
- Partials 7198 7260 +62
🚀 New features to boost your workflow:
|
anonrig
reviewed
Jun 11, 2025
Co-authored-by: Yagiz Nizipli <[email protected]>
marco-ippolito
approved these changes
Jun 16, 2025
This test failed, but it seems to have nothing to do with my changes. Can someone help me take a look? What else do I need to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix type in getTypeScriptParsingMode's jsdoc:
@type {string}
should be@type {() => TypeScriptMode}
@marco-ippolito