Skip to content

[v22.x backport] esm: implement import.meta.main #58693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: v22.x-staging
Choose a base branch
from
Open

[v22.x backport] esm: implement import.meta.main #58693

wants to merge 6 commits into from
+241 −16

Conversation

Lordfirespeed
Copy link
Contributor

Backport #57804 to v22.x release line

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jun 12, 2025
@Lordfirespeed Lordfirespeed changed the title [Backport v22.x] esm: implement import.meta.main [v22.x backport] esm: implement import.meta.main Jun 12, 2025
@alexsch01
Copy link
Contributor

Should include #58661 if it doesn't already

@aduh95
Copy link
Contributor

aduh95 commented Jun 12, 2025

We should only pick the commits that have landed on main, this PR have 47 commits that are not on main

@Lordfirespeed
Copy link
Contributor Author

Ah, my bad, I probably picked commits from the wrong branch.

Lordfirespeed and others added 4 commits June 13, 2025 19:15
@Lordfirespeed @aduh95
esm: implement import.meta.main
33f6fbd 
Boolean value to check if an ES Module is the entrypoint of the
current process.

Implements: nodejs#57226

Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: nodejs#57804
Fixes: nodejs#57226
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
(cherry picked from commit bbc0593)
@marco-ippolito @Lordfirespeed
module: fix typescript import.meta.main
d8d3b07 
PR-URL: nodejs#58661
Fixes: nodejs#58660
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
(cherry picked from commit bba07d7)
@Lordfirespeed
document isEntryPoint parameter in JSDoc
8da021f
@Lordfirespeed
fix: do not supply undefined for phase parameter
8868f38 
`phase` parameter doesn't exist in v22.x
@Lordfirespeed Lordfirespeed force-pushed the backport-import-meta-main-to-v22.x branch from e529a26 to 8868f38 Compare June 13, 2025 18:18
@Lordfirespeed
Copy link
Contributor Author

Lordfirespeed commented Jun 13, 2025 •
edited
Loading

@aduh95 to adhere to the 'only commits that landed' rule, should I squash the new commits into a landed commit? or are commits for manual resolution after cherry-picking OK?

@Lordfirespeed
Copy link
Contributor Author

What's the deal here? I don't understand why CI is failing 🤔

@aduh95
Copy link
Contributor

aduh95 commented Jun 20, 2025

@aduh95 to adhere to the 'only commits that landed' rule, should I squash the new commits into a landed commit? or are commits for manual resolution after cherry-picking OK?

You can use git commit --fixup <commit-sha>, so it's easier to review and squash those additional commits upon landing.

What's the deal here? I don't understand why CI is failing 🤔

It looks like the Coverage CI is broken on that branch, unrelated to your changes. The macOS one timed out, also probably unrelated to your changes.

@marco-ippolito
Copy link
Member

marco-ippolito commented Jun 25, 2025 •
edited
Loading

can you include bba07d7 in the backport (if lands cleanly otherwise I can open a backport)

@Lordfirespeed
Copy link
Contributor Author

Lordfirespeed commented Jun 25, 2025 •
edited
Loading

can you include bba07d7 in the backport (if lands cleanly otherwise I can open a backport)

'In addition to' or 'instead of' d8d3b07 (which is currently included) ?

@marco-ippolito
Copy link
Member

marco-ippolito commented Jun 25, 2025 •
edited
Loading

Sorry I didnt notice it was already included. Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lordfirespeed @nodejs-github-bot @alexsch01 @aduh95 @marco-ippolito