-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
repl: fix eval errors thrown after close throwing ERR_USE_AFTER_CLOSE
#58791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repl: fix eval errors thrown after close throwing ERR_USE_AFTER_CLOSE
#58791
Conversation
prevent incorrect throws of `ERR_USE_AFTER_CLOSE` errors when the eval function of a repl server returns an error after the repl server has been closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58791 +/- ##
==========================================
- Coverage 90.10% 90.09% -0.01%
==========================================
Files 640 640
Lines 188287 188291 +4
Branches 36916 36926 +10
==========================================
- Hits 169651 169636 -15
- Misses 11355 11385 +30
+ Partials 7281 7270 -11
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGMT
I have confirmed that this patch fixes my issue. |
Commit Queue failednode:internal/modules/esm/resolve:275 throw new ERR_MODULE_NOT_FOUND( ^https://github.com/nodejs/node/actions/runs/15943283499 |
Landed in 9fe3316 |
prevent incorrect throws of `ERR_USE_AFTER_CLOSE` errors when the eval function of a repl server returns an error after the repl server has been closed PR-URL: #58791 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
prevent incorrect throws of `ERR_USE_AFTER_CLOSE` errors when the eval function of a repl server returns an error after the repl server has been closed PR-URL: #58791 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Fixes #58784
prevent incorrect throws of
ERR_USE_AFTER_CLOSE
errors when the eval function of a repl server returns an error after the repl server has been closed