-
-
Notifications
You must be signed in to change notification settings - Fork 32k
test_runner: correctly filter --experimental-config-file #58833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58833 +/- ##
==========================================
- Coverage 90.10% 90.08% -0.02%
==========================================
Files 640 640
Lines 188384 188453 +69
Branches 36932 36970 +38
==========================================
+ Hits 169735 169775 +40
- Misses 11356 11395 +39
+ Partials 7293 7283 -10
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 LGTM
There's a related failing CI, I'll investigate ASAP |
Ah, yes. Looks like |
https://github.com/nodejs/node/blob/main/test%2Fparallel%2Ftest-coverage-with-inspector-disabled.js <-- I keep forgetting this every time: coverage-related tests must be skipped under specific cases 😁 I'll update the test ASAP |
TIL 💡 |
Opening as a draft since I need to add at least one test to cover the regression.
Should address #58828