Skip to content

benchmark: remove deprecated _extend from benchmark #59228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Aug 11, 2025
Merged

benchmark: remove deprecated _extend from benchmark #59228

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d62018
benchmark: remove deprecated _extend from benchmark
RafaelGSS Jul 26, 2025
c6c2fb5
fixup! benchmark: remove deprecated _extend from benchmark
RafaelGSS Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions benchmark/es/spread-assign.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
'use strict';

const common = require('../common.js');
const util = require('util');
const assert = require('node:assert');

const bench = common.createBenchmark(main, {
method: ['spread', 'assign', '_extend'],
method: ['spread', 'assign'],
count: [5, 10, 20],
n: [1e6],
});

function main({ n, context, count, rest, method }) {
function main({ n, count, method }) {

const src = {};
for (let n = 0; n < count; n++)
Expand All @@ -18,12 +18,6 @@ function main({ n, context, count, rest, method }) {
let obj;

switch (method) {
case '_extend':
bench.start();
for (let i = 0; i < n; i++)
obj = util._extend({}, src);
bench.end(n);
break;
case 'assign':
bench.start();
for (let i = 0; i < n; i++)
Expand All @@ -33,10 +27,11 @@ function main({ n, context, count, rest, method }) {
case 'spread':
bench.start();
for (let i = 0; i < n; i++)
obj = { ...src }; // eslint-disable-line no-unused-vars
obj = { ...src };
bench.end(n);
break;
default:
throw new Error('Unexpected method');
}
assert.ok(obj);
}
Loading