Skip to content

tools: copyedit build-tarball.yml #59808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Sep 10, 2025
Merged

tools: copyedit build-tarball.yml #59808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions .github/workflows/build-tarball.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,14 @@ jobs:
- name: Make tarball
run: |
export DISTTYPE=nightly
export DATESTRING=`date "+%Y-%m-%d"`
export DATESTRING=$(date "+%Y-%m-%d")
export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA")
./configure && make tar -j8 SKIP_XZ=1
mkdir tarballs
mv *.tar.gz tarballs
./configure && make tar -j4 SKIP_XZ=1
- name: Upload tarball artifact
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: tarballs
path: tarballs
path: '*.tar.gz'
Comment on lines -64 to +62
Copy link
Contributor

@bnb bnb Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking at all, I just want to ask what the previous behavior here was with tarballs as the value - it's surprising to me that it worked.

Copy link
Contributor Author

@aduh95 aduh95 Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was creating a folder with that name:

node/.github/workflows/build-tarball.yml

Lines 58 to 59 in 2a99210

mkdir tarballs
mv *.tar.gz tarballs

compression-level: 0
test-tarball-linux:
needs: build-tarball
Expand Down Expand Up @@ -97,11 +95,10 @@ jobs:
path: tarballs
- name: Extract tarball
run: |
tar xzf tarballs/*.tar.gz -C $RUNNER_TEMP
echo "TAR_DIR=$RUNNER_TEMP/`basename tarballs/*.tar.gz .tar.gz`" >> $GITHUB_ENV
tar xzf tarballs/*.tar.gz -C "$RUNNER_TEMP"
echo "TAR_DIR=$RUNNER_TEMP/$(basename tarballs/*.tar.gz .tar.gz)" >> "$GITHUB_ENV"
- name: Build
run: |
make -C "$TAR_DIR" build-ci -j4 V=1
run: make -C "$TAR_DIR" build-ci -j4 V=1
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
persist-credentials: false
Expand All @@ -113,5 +110,4 @@ jobs:
mv tools/eslint "$TAR_DIR/tools"
mv tools/eslint-rules "$TAR_DIR/tools"
- name: Test
run: |
make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"
run: make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"
Loading