doc: fix typo in fs writeSync param list#5984
Closed
firedfox wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Rename `buffer` to `data` in param list of fs.writeSync(fd, data[, position[, encoding]])
mscdex
added
doc
Contributor
|
LGTM |
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Apr 1, 2016
Rename `buffer` to `data` in param list of fs.writeSync(fd, data[, position[, encoding]]) PR-URL: #5984 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in d939152 |
Contributor
|
this change appears to make changes to copy that does not exist on v4 or v5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
If this change fixes a bug (or a performance problem), is a regressiontest (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
Description of change
Change
buffertodatain the param list offs.writeSync(fd, data[, position[, encoding]])