Skip to content

tools: fix tools/make-v8.sh for clang #59893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Sep 17, 2025
Merged

tools: fix tools/make-v8.sh for clang #59893

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cace72
tools: fix `tools/make-v8.sh` for clang
richardlau Sep 15, 2025
626b5e3
fixup! tools: fix `tools/make-v8.sh` for clang
richardlau Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 5 additions & 24 deletions tools/make-v8.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,37 +20,18 @@
if [ "$ARCH" = "ppc64le" ]; then
TARGET_ARCH="ppc64"
fi
# set paths manually for now to use locally installed gn
export BUILD_TOOLS=/home/iojs/build-tools
export LD_LIBRARY_PATH="$BUILD_TOOLS:$LD_LIBRARY_PATH"
rm -f "$BUILD_TOOLS/g++"
rm -f "$BUILD_TOOLS/gcc"
# V8's build config looks for binaries called `gcc` and `g++` if not using
# clang. Ensure that `gcc` and `g++` point to the compilers we want to
# invoke, creating symbolic links placed at the front of PATH, if needed.
# Avoid linking to ccache symbolic links as ccache decides which binary
# to run based on the name of the link (i.e. `gcc`/`g++` in our case).
# shellcheck disable=SC2154
if [ "$CC" != "" ] && [ "$CC" != "gcc" ]; then
CC_PATH=$(command -v "$CC" gcc | grep -v ccache | head -n 1)
ln -s "$CC_PATH" "$BUILD_TOOLS/gcc"
fi
# shellcheck disable=SC2154
if [ "$CXX" != "" ] && [ "$CXX" != "g++" ]; then
CXX_PATH=$(command -v "$CXX" g++ | grep -v ccache | head -n 1)
ln -s "$CXX_PATH" "$BUILD_TOOLS/g++"
fi
export PATH="$BUILD_TOOLS:$PATH"
# Propagate ccache to gn.
case "$CXX" in

Check failure on line 24 in tools/make-v8.sh

View workflow job for this annotation

GitHub Actions / lint-sh 

/home/runner/work/node/node/tools/make-v8.sh:24:9: CXX is referenced but not assigned.
*ccache*) CC_WRAPPER="cc_wrapper=\"ccache\"" ;;
*) ;;
esac

g++ --version
gcc --version
case "$CXX" in
*clang*) GN_COMPILER_OPTS="is_clang=true clang_base_path=\"/usr\" clang_use_chrome_plugins=false treat_warnings_as_errors=false use_custom_libcxx=false" ;;
*) GN_COMPILER_OPTS="treat_warnings_as_errors=false use_custom_libcxx=false" ;;
esac
export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config

Check failure on line 33 in tools/make-v8.sh

View workflow job for this annotation

GitHub Actions / lint-sh 

/home/runner/work/node/node/tools/make-v8.sh:33:26: Double quote to prevent globbing and word splitting.

Check failure on line 33 in tools/make-v8.sh

View workflow job for this annotation

GitHub Actions / lint-sh 

/home/runner/work/node/node/tools/make-v8.sh:33:26: BUILD_TOOLS is referenced but not assigned.
gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true $CC_WRAPPER"
gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="$GN_COMPILER_OPTS is_component_build=false is_debug=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true $CC_WRAPPER"
ninja -v -C "out.gn/$BUILD_ARCH_TYPE" "${JOBS_ARG}" d8 cctest inspector-test
else
DEPOT_TOOLS_DIR="$(cd depot_tools && pwd)"
Expand Down
Loading