Skip to content

deps: update V8 to 14.3 #60488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 14 commits into from
Closed

deps: update V8 to 14.3 #60488

targos wants to merge 14 commits into from

Conversation

@targos
Copy link
Member

@targos targos commented Oct 29, 2025

No description provided.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 29, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 29, 2025
@targos

This comment was marked as resolved.

Sign in to view
cjihrig
cjihrig approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@legendecas

This comment was marked as resolved.

Sign in to view
@legendecas

This comment was marked as resolved.

Sign in to view
targos and others added 11 commits November 12, 2025 14:03
@targos
deps: update V8 to 14.3.127.12
3e74840
@targos
build: reset embedder string to "-node.0"
5856653
@targos
src: update NODE_MODULE_VERSION to 144
16e4414 
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 14.3.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
@targos
deps: patch V8 to avoid duplicated zlib symbol
286715c 
PR-URL: nodejs#54077
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@StefanStojanovic @targos
deps: define V8_PRESERVE_MOST as no-op on Windows
86838c8 
It's causing linker errors with node.lib in node-gyp and potentially
breaks other 3rd party tools

PR-URL: nodejs#56238
Refs: nodejs#55784
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos
deps: remove problematic comment from v8-internal
10bef09 
GCC emits warnings because of the trailing backslashes.

PR-URL: nodejs#58070
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@joyeecheung @targos
deps: use std::map in MSVC STL for EphemeronRememberedSet
21ca1a9 
PR-URL: nodejs#58070
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danmcd @targos
deps: patch V8 for illumos
55ab9c4 
illumos pointers are VA48, can allocate from the top of the 64-bit range
as well.

PR-URL: nodejs#59805
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@danmcd @targos
deps: support madvise(3C) across ALL illumos revisions
9c5411a 
In illumos, madvise(3C) now takes `void *` for its first argument
post-illumos#14418, but uses `caddr_t` pre-illumos#14418. This fix will
detect if the illumos mman.h file in use is pre-or-post-illumos#14418 so
builds can work either way.

PR-URL: nodejs#58237
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos
deps: V8: backport 2e4c5cf9b112
a711e2d 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <[email protected]>
    Commit-Queue: Milad Farazmand <[email protected]>
    Reviewed-by: Thibaud Michaud <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <[email protected]>
PR-URL: nodejs#60654
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
@jakobkummerow @targos
deps: V8: cherry-pick 47800791b35c
aff1044 
Original commit message:

    [wasm] Fix DCHECK in AtomicWait after memory growth

    With the changes in crrev.com/c/7003085, calling memory.grow()
    via the JS API didn't immediately update the memory's array buffer
    any more, which triggered a DCHECK in the runtime functions for
    atomic waits. This patch restores immediate updating of the buffer
    for the current isolate, which maintains the other CL's goal to
    not allocate on loop back edges.

    Fixed: 454991459
    Change-Id: Id633cebb9ac24606bc0d8a3df703c74531d3c8a0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7100806
    Reviewed-by: Clemens Backes <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Auto-Submit: Jakob Kummerow <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#103431}

Refs: v8/v8@4780079
@targos
Copy link
Member Author

targos commented Nov 12, 2025

V8 CI is broken: https://ci.nodejs.org/job/node-test-commit-v8-linux/6849/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console

@targos
Copy link
Member Author

targos commented Nov 12, 2025

It's not V8 CI. It's GCC compatibility.

abmusse and others added 3 commits November 12, 2025 15:53
@abmusse @targos
deps: V8: backport 151d0a44a1b2
7802d76 
Original commit message:

    Fix gcc build

    For json-parser.h:

    ```
    ../../src/json/json-parser.h:298:13: error: explicit specialization in
    non-namespace scope 'class v8::internal::JsonParser<Char>'
      298 |   template <>
          |             ^
    ../../src/json/json-parser.h:299:18: error: template-id
    'IsNextToken<v8::internal::JsonToken::EOS>' in declaration of primary template
      299 |   V8_INLINE bool IsNextToken<JsonToken::EOS>() {
          |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ```

    For wasm-objects.cc:
    ```
    ../../src/wasm/wasm-objects.cc:2522:45: error: no matching function for call to
    'v8::internal::WasmDispatchTable::SetForNonWrapper<v8::internal::WasmDispatchTable>(
     v8::internal::WasmDispatchTable&, int&, v8::internal::Tagged<v8::internal::
     Union<v8::internal::Smi, v8::internal::WasmTrustedInstanceData> >&,
     v8::internal::WasmCodePointer&, v8::internal::wasm::CanonicalTypeIndex&,
     v8::internal::WasmDispatchTable::NewOrExistingEntry&)'
    ```

    ```
    error: no matching function for call to 'v8::internal::WasmDispatchTable::
    SetForWrapper<v8::internal::WasmDispatchTable>(v8::internal::WasmDispatchTable&,
    int&, v8::internal::Tagged<v8::internal::WasmImportData>&, std::shared_ptr<v8::
    internal::wasm::WasmImportWrapperHandle>&, v8::internal::wasm::
    CanonicalTypeIndex&, v8::internal::WasmDispatchTable::NewOrExistingEntry&)'
    ```

    For the fix fully qualify calls to SetForWrapper and SetForNonWrapper with
    ::v8::internal:: to avoid accidental lookup of class member names.
    This resolves template resolution errors caused by unqualified
    calls inside WasmDispatchTable and WasmDispatchTableForImports
    member functions.

    Change-Id: I687935a05dc754db686deaa0f93079d350aae07e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7107891
    Reviewed-by: Patrick Thier <[email protected]>
    Reviewed-by: Manos Koukoutos <[email protected]>
    Commit-Queue: Milad Farazmand <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#103547}

Refs: v8/v8@151d0a4
Co-authored-by: Michaël Zasso <[email protected]>
@targos
src: remove deprecated and unused isolate fields
836cc7a 
Refs: v8/v8@599866f
@targos
test: fix test-linux-perf-logger for V8 14.3
b4cbe23 
Refs: v8/v8@e2e6dd8
@targos
Copy link
Member Author

targos commented Nov 12, 2025

I found v8/v8@151d0a4

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6851/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6851/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70152/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6851/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 13, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70155/

@targos
Copy link
Member Author

targos commented Nov 13, 2025

This is ready @nodejs/tsc @nodejs/v8-update

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2025
@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 13, 2025
@richardlau richardlau mentioned this pull request Nov 13, 2025
Merged
targos added a commit that referenced this pull request Nov 13, 2025
@targos
deps: update V8 to 14.3.127.12
53379f3 
PR-URL: #60488
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Nov 13, 2025
@targos
build: reset embedder string to "-node.0"
908c468 
PR-URL: #60488
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos
Copy link
Member Author

targos commented Nov 13, 2025

Landed in c208ffc...092a448

targos added a commit that referenced this pull request Nov 13, 2025
@targos
src: update NODE_MODULE_VERSION to 144
70b6bd8 
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 14.3.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: #60488
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos closed this Nov 13, 2025
targos pushed a commit that referenced this pull request Nov 13, 2025
@jakobkummerow @targos
deps: V8: cherry-pick 47800791b35c
b59af77 
Original commit message:

    [wasm] Fix DCHECK in AtomicWait after memory growth

    With the changes in crrev.com/c/7003085, calling memory.grow()
    via the JS API didn't immediately update the memory's array buffer
    any more, which triggered a DCHECK in the runtime functions for
    atomic waits. This patch restores immediate updating of the buffer
    for the current isolate, which maintains the other CL's goal to
    not allocate on loop back edges.

    Fixed: 454991459
    Change-Id: Id633cebb9ac24606bc0d8a3df703c74531d3c8a0
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7100806
    Reviewed-by: Clemens Backes <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Auto-Submit: Jakob Kummerow <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#103431}

Refs: v8/v8@4780079
PR-URL: #60488
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Nov 13, 2025
@abmusse @targos
deps: V8: backport 151d0a44a1b2
bf5c6a8 
Original commit message:

    Fix gcc build

    For json-parser.h:

    ```
    ../../src/json/json-parser.h:298:13: error: explicit specialization in
    non-namespace scope 'class v8::internal::JsonParser<Char>'
      298 |   template <>
          |             ^
    ../../src/json/json-parser.h:299:18: error: template-id
    'IsNextToken<v8::internal::JsonToken::EOS>' in declaration of primary template
      299 |   V8_INLINE bool IsNextToken<JsonToken::EOS>() {
          |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ```

    For wasm-objects.cc:
    ```
    ../../src/wasm/wasm-objects.cc:2522:45: error: no matching function for call to
    'v8::internal::WasmDispatchTable::SetForNonWrapper<v8::internal::WasmDispatchTable>(
     v8::internal::WasmDispatchTable&, int&, v8::internal::Tagged<v8::internal::
     Union<v8::internal::Smi, v8::internal::WasmTrustedInstanceData> >&,
     v8::internal::WasmCodePointer&, v8::internal::wasm::CanonicalTypeIndex&,
     v8::internal::WasmDispatchTable::NewOrExistingEntry&)'
    ```

    ```
    error: no matching function for call to 'v8::internal::WasmDispatchTable::
    SetForWrapper<v8::internal::WasmDispatchTable>(v8::internal::WasmDispatchTable&,
    int&, v8::internal::Tagged<v8::internal::WasmImportData>&, std::shared_ptr<v8::
    internal::wasm::WasmImportWrapperHandle>&, v8::internal::wasm::
    CanonicalTypeIndex&, v8::internal::WasmDispatchTable::NewOrExistingEntry&)'
    ```

    For the fix fully qualify calls to SetForWrapper and SetForNonWrapper with
    ::v8::internal:: to avoid accidental lookup of class member names.
    This resolves template resolution errors caused by unqualified
    calls inside WasmDispatchTable and WasmDispatchTableForImports
    member functions.

    Change-Id: I687935a05dc754db686deaa0f93079d350aae07e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7107891
    Reviewed-by: Patrick Thier <[email protected]>
    Reviewed-by: Manos Koukoutos <[email protected]>
    Commit-Queue: Milad Farazmand <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#103547}

Refs: v8/v8@151d0a4
Co-authored-by: Michaël Zasso <[email protected]>
PR-URL: #60488
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Nov 13, 2025
@targos
src: remove deprecated and unused isolate fields
8480f87 
Refs: v8/v8@599866f
PR-URL: #60488
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos added a commit that referenced this pull request Nov 13, 2025
@targos
test: fix test-linux-perf-logger for V8 14.3
092a448 
Refs: v8/v8@e2e6dd8
PR-URL: #60488
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos targos deleted the v8-143 branch November 13, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.