Skip to content

deps: update libuv to 1.53.0 - #66282

Open
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-libuv
Open

nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/tools-update-libuv

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of libuv to 1.53.0.

@nodejs-github-bot nodejs-github-bot added the dependencies PRs that add, update, or configure Node.js dependencies. label Sep 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Sep 25, 2026
@panva

panva commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

This should also fix the SmartOS test-worker-init-failure flake in the reliability report, introduced by #65796.

Switching V8's entropy source to uv_random() made worker initialization open /dev/urandom on SmartOS. Under the test's deliberate file-descriptor exhaustion, that can abort the entire process instead of reporting a worker initialization error. libuv/libuv#5187 (part of this release) switches to getrandom(2), removing that descriptor dependency.

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 25, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@richardlau

Copy link
Copy Markdown
Member

https://github.com/nodejs/node/actions/runs/36140009857/job/108087238784?pr=66282#step:6:4886

lld-link : error : undefined symbol: WaitOnAddress [D:\a\node\node\node_js2c.vcxproj]
  >>> referenced by D:\a\node\node\deps\uv\src\win\pipe.c:1066
  >>>               libuv.lib(pipe.obj):(uv__pipe_cancel_synchronous_io)
  
lld-link : error : undefined symbol: WakeByAddressSingle [D:\a\node\node\node_js2c.vcxproj]
  >>> referenced by D:\a\node\node\deps\uv\src\win\pipe.c:1450
  >>>               libuv.lib(pipe.obj):(uv__pipe_begin_synchronous_io)
  >>> referenced by D:\a\node\node\deps\uv\src\win\pipe.c:1460
  >>>               libuv.lib(pipe.obj):(uv__pipe_begin_synchronous_io)

@aduh95 aduh95 removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 25, 2026
@aduh95

aduh95 commented Sep 25, 2026

Copy link
Copy Markdown
Contributor
---
duration_ms: 221.414
exitcode: 1
severity: fail
stack: |-
  node:internal/assert/utils:146
    throw error;
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

  true !== false

      at Object.<anonymous> (/home/iojs/build/workspace/node/test/parallel/test-blocklist.js:891:10)
      at Module._compile (node:internal/modules/cjs/loader:1956:14)
      at Object..js (node:internal/modules/cjs/loader:2096:10)
      at Module.load (node:internal/modules/cjs/loader:1678:32)
      at Module._load (node:internal/modules/cjs/loader:1470:12)
      at wrapModuleLoad (node:internal/modules/cjs/loader:261:19)
      at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:171:5)
      at node:internal/main/run_main_module:33:47 {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: true,
    expected: false,
    operator: 'strictEqual',
    diff: 'simple'
  }

  Node.js v27.0.0-pre
...

@jonathanlindsay

Copy link
Copy Markdown

This release includes libuv/libuv#5181, which fixes spawn with 'pipe'/'ipc' hanging inside a Windows AppContainer. Requesting it for v24.x as well once it lands: #66374.

@ywkuno

ywkuno commented Oct 2, 2026 •

Copy link
Copy Markdown

Hi, I looked into the two CI failures on this PR and have fixes on a branch, in case they're useful:
actions/tools-update-libuv...ywkuno:node:libuv-1.53-followups

Windows link failure. libuv 1.53's pipe code now calls WaitOnAddress / WakeByAddressSingle, which live in Synchronization.lib. Node's uv.gyp doesn't link that library, so the build fails with LNK2019 for both symbols (from libuv.lib(pipe.obj)), then LNK1120 in node_js2c.exe. I reproduced this at d44f17a with VS 17.14 / MSVC 19.44.
50a0710 deps: link Synchronization.lib in uv.gyp
b559a3a deps: link Synchronization.lib in uv GN build. This is the corresponding change for unofficial.gni; I haven't built with GN yet.
With these, node.exe links and process.versions.uv is 1.53.0.

test-blocklist failure on Linux. libuv 1.53 includes the change from 6179e7af, which replaces the hard-coded IPv6 address buffer size in uv_ip6_addr() with INET6_ADDRSTRLEN. Longer zoned IPv6 address parts are therefore parsed instead of being truncated at the old limit. FastCheckString() still rejects address parts of 40+ characters, so the fast and slow BlockList paths disagree for the same string. That's the test-blocklist.js:891 failure. I reproduced it on Fedora 44 / GCC 16.2.
59eedfa net: align BlockList fast path with uv_ip6_addr. It truncates the address part to INET6_ADDRSTRLEN - 1, matching uv_ip6_addr(), updates the test-blocklist expectation, and adds a fast-API test comparing both paths. It depends on the libuv 1.53 behavior, so it belongs with this update.
test-blocklist.js and test-blocklist-fast-api.js pass; make lint-js, lint-cpp and format-cpp are clean; core-validate-commit passes.

I used a closed-source coding agent to help investigate and draft these. I reviewed the changes, reproduced both failures and verified the fixes myself, and I'm happy to explain or adjust anything. Feel free to cherry-pick or adapt them into this PR, or let me know if you'd rather have a separate PR.

nodejs-github-bot pushed a commit that referenced this pull request Oct 3, 2026
Track the descriptor-dependent V8 entropy failure until the libuv update
in #66282 removes the dependency on opening /dev/urandom.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: #66428
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Oct 3, 2026
Track the descriptor-dependent V8 entropy failure until the libuv update
in #66282 removes the dependency on opening /dev/urandom.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: #66428
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Oct 3, 2026
Track the descriptor-dependent V8 entropy failure until the libuv update
in #66282 removes the dependency on opening /dev/urandom.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: #66428
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot
nodejs-github-bot force-pushed the actions/tools-update-libuv branch from d44f17a to 97d2771 Compare October 4, 2026 01:29
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.51%. Comparing base (1c90519) to head (b473a45).

Files with missing lines Patch % Lines
src/node_sockaddr.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66282      +/-   ##
==========================================
+ Coverage   90.49%   90.51%   +0.01%     
==========================================
  Files         797      797              
  Lines      277598   277598              
  Branches    53336    53328       -8     
==========================================
+ Hits       251220   251259      +39     
+ Misses      16790    16749      -41     
- Partials     9588     9590       +2     
Files with missing lines Coverage Δ
src/node_sockaddr.cc 75.33% <0.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
nodejs-github-bot force-pushed the actions/tools-update-libuv branch from 6cf6d6c to 834d87a Compare October 11, 2026 01:04
@aduh95
aduh95 force-pushed the actions/tools-update-libuv branch from 834d87a to 7953577 Compare October 11, 2026 22:36
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

mickem added a commit to mickem/nscp that referenced this pull request Oct 13, 2026
`npm run test:stress` on Windows died now and then with no output: node
exited with 0xC0000409 and jest's RUNS line just stopped. A crash dump
taken with procdump and symbolised against node's public PDB shows a
stack-cookie failure (__report_gsfailure) in uv__tcp_connect, reached
from TCPWrap::Connect. On every loopback connect, libuv passes an
uninitialised OSVERSIONINFOW to RtlGetVersion; when the stack garbage
reads as the size of the larger OSVERSIONINFOEXW, RtlGetVersion writes
8 bytes past it. This is libuv #5106, fixed in libuv 1.53.0. Every
released node, 18 through 26.11.1, ships an older libuv
(nodejs/node#66282 is still open), and the NRPE and NSCA floods open
millions of loopback connections per run.

The floods' connections now come from stress/lib/socket_pump.py, a
standard-library Python helper driven over stdin/stdout by
socket-pump.ts. It knows no protocol: NrpeClient and NscaClient still
build and check every packet in TypeScript, and the pump only connects
(with TLS if asked), writes, and reads until the agent closes. For NSCA
it hands the IV back to node in the middle of the exchange. Requests
are spread over four pump processes (NSCP_STRESS_PUMPS), because one
topped out at ~3900 NSCA submissions/s.

Once the agent has closed, the pump hangs up with a linger-0 reset, so
neither side keeps the connection in TIME_WAIT. Without that, the
agent's side held one TIME_WAIT pair per client port after a plain
flood, and the TLS flood that followed on the same port had SYNs from
reused ports dropped (21 s connect timeouts, WinError 121). The pump
uses the selector event loop: the Windows proactor transport sends a
FIN before closing, so it never resets.

NSCP_STRESS_SOCKETS picks the transport. The stress global setup
defaults it to python; it stays node everywhere else, so
engine-concurrency.test.ts, which borrows the NRPE client, needs no
Python. NrpeClient takes its TLS client certificate as files, which
Python's ssl needs. The full suite passed 10/10 on Windows, plain NRPE
at 10918 requests/s (node managed 5506) and NSCA at 6234/s.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Michael Medin <michael@medin.name>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@aduh95
aduh95 force-pushed the actions/tools-update-libuv branch from 7953577 to b473a45 Compare October 15, 2026 16:44
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@nodejs-github-bot
nodejs-github-bot force-pushed the actions/tools-update-libuv branch from 630cbe1 to 6664b6c Compare November 15, 2026 00:35
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 19, 2026
@ronag
ronag requested a review from jasnell November 19, 2026 20:14
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 19, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@ronag

ronag commented Nov 20, 2026

Copy link
Copy Markdown
Member

@richardlau

@richardlau

Copy link
Copy Markdown
Member

@richardlau

@ronag was there something specific I was at-mentioned for?

AFAICT @aduh95 was trying to address the RHEL 8 failures in b473a45 (which I think the bot has dropped from this PR), but it sounds like something that should either be fixed in upstream libuv or we can turn off testing on RHEL 8 for Node.js 27/main (as we bumped the minimum requirements in #66377) but would mean that we would not be able to land this libuv update in earlier (e.g. Node.js 26) release lines.

@ronag

ronag commented Nov 20, 2026

Copy link
Copy Markdown
Member

@richardlau

@ronag was there something specific I was at-mentioned for?

AFAICT @aduh95 was trying to address the RHEL 8 failures in b473a45 (which I think the bot has dropped from this PR), but it sounds like something that should either be fixed in upstream libuv or we can turn off testing on RHEL 8 for Node.js 27/main (as we bumped the minimum requirements in #66377) but would mean that we would not be able to land this libuv update in earlier (e.g. Node.js 26) release lines.

Ping was for redhat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies PRs that add, update, or configure Node.js dependencies. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants