Skip to content

Adding NodeJS Discord community to get involved page #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Adding NodeJS Discord community to get involved page #1932

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c035e53
Adding NodeJS Discord community to get involved page
Dec 11, 2018
53abbaf
Update index.md
Dec 11, 2018
67ffcce
Update locale/en/get-involved/index.md
sonicdoe Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions locale/en/get-involved/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,4 @@ The Node.js community is large, inclusive, and excited to enable as many users t
- [Spanish language Facebook group for Node.js](https://www.facebook.com/groups/node.es/)
- [Spanish language community](http://nodehispano.com)
- [Việt Nam Node.js community](http://nodejs.vn)
- [Node.js Discord community](https://discord.gg/Uaq5RHu) - (unofficial)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This seems to be in the wrong place. This would be a better fit in the "Community Discussion" section, it seems, although only because of the oddball inclusion of NodeUp in that section. TBH, this whole page seems a bit of a hodgepodge. It's not clear what kind of getting involved is included on this page and what kind of getting involved isn't.

  • There is no need to say "(unofficial)". All (or nearly all?) of these are unofficial. My comment about it being unofficial wasn't a comment on the contents of the PR. It was a response to this comment: Adding NodeJS Discord community to get involved page #1932 (comment)

  • It seems wrong to include Node.js Discord and not NodeSlackers.