Remove ARMv6 from releases starting v12.0.0 #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @nodejs/build |
richardlau
requested changes
Apr 24, 2019
richardlau
approved these changes
Apr 24, 2019
refack
approved these changes
Apr 24, 2019
ZYSzys
reviewed
Apr 24, 2019
scripts/helpers/downloads.js
Outdated
| @@ -147,6 +147,11 @@ module.exports = (version) => { | |||
| downloads = downloads.filter(ver => | |||
| ver.title !== 'Linux 32-bit Binary' && | |||
| ver.title !== 'SmartOS 32-bit Binary') | |||
| } else if (semver.satisfies(version, '>= 12.0.0')) { | |||
There was a problem hiding this comment.
IIUC, this condition seems unreachable since it would be caught by semver.satisfies(version, '>= 10.0.0') in the line 146:
nodejs.org/scripts/helpers/downloads.js
Line 146 in 8216eeb
There was a problem hiding this comment.
You are right, of course. Stupid copy & paste mistake.
I refactored the download helper, PTAL.
BethGriggs
approved these changes
Apr 24, 2019
rvagg
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: