Skip to content

removed unused i18n keys #6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2024
Merged

removed unused i18n keys #6245

merged 1 commit into from
Jan 14, 2024

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Jan 14, 2024

@ovflowd asked me to review all internationalization keys. These are unused.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner January 14, 2024 20:48
Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 8:49pm

Copy link
Contributor

github-actions bot commented Jan 14, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 98 🟢 96 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 97 🟢 92 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
86.88% (391/450) 73.1% (106/145) 80.23% (69/86)

Unit Test Report

Tests Skipped Failures Errors Time
72 0 💤 0 ❌ 0 🔥 4.196s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Jan 14, 2024

Ty! I bet there will be more keys once we remove the legacy website. I genuinely thought there would be more key 🤔

@ovflowd ovflowd added this pull request to the merge queue Jan 14, 2024
Merged via the queue into main with commit 0b76412 Jan 14, 2024
@ovflowd ovflowd deleted the i18n-key-audit branch January 14, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants