-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(pride logo): introduce #6734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I'm trying to say is that you can merge all the Node.js logo variants into a single React Component, they are after all a React Component.
This (what you did below) is not what I was referring to, and does not reduce the duplication of code.
Try to reflect a bit on how to achieve what I'm saying. It's pretty simple actually ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thinks I go your idea just just want one nodejsLogo
stroke of text will be apply with tailwind and two other component for Hexagon
I'm thinking we get this released sooner rather than later, even if we aren't in complete alignment on the approach. |
We want to release this ASAP. We can refactor at any time after this. But pride month has started
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content over purity of engineering
ugh - on mobile this all looked green - something's wrong post-merge - looking into it |
I thinks It’s small delay from Vercel deployment |
Oh my bad I thinks you talk about logo 😅 |
i'm glad its not outright broken, but apologies on any instability i rushed through - mobile is clearly not a good way to review CI status checks - thought i see here everything looks green. i suggest we simply roll forward with a merge of a dependency update or something |
Description
Read issues #6733 to understand what is going on.
Validation
Related Issues
Related to #6733
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.