Skip to content

Added 2023-05-15 meeting notes #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions meetings/2023-05-15.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# Node.js Performance Team Meeting 2023-05-15

## Links

* **Recording**: https://www.youtube.com/watch?v=wTQYyxSViVg
* **GitHub Issue**: https://github.com/nodejs/performance/issues/78

## Present

* Performance team: @nodejs/performance
* Yagiz Nizipli: @anonrig
* Ulises Gascon: @ulisesGascon
* Robert Nagy: @ronag
* Debadree Chatterjee: @debadree25
* Vinicius Lourenço: @H4ad

## Agenda

## Announcements





*Extracted from **performance-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### nodejs/performance

* Improve legacy CJS resolve [#73](https://github.com/nodejs/performance/issues/73)
* Nodejs is performing several c++ calls to `new URL` when running `fileExists` that can be simplified into a single C++ call.
* This issue is open to contribution from the community.

* MakeCallback is very slow [#24](https://github.com/nodejs/performance/issues/24)
* C++ is calling JS, this is very slow due Async hooks.
* This scenario happened in the past in other parts of Node.js
* There is a path to explore: flag to control async hooks. That way we can avoid async hook when they are not needed.
* We want to involve more relevant contributors in this issue. We will ping them in the issue
* fetch [#11](https://github.com/nodejs/performance/issues/11)
* There are no news
* Readable streams should be the focus from now on: https://github.com/nodejs/performance/issues/82
* PR from Debadree related to this: https://github.com/anonrig/node-benchmarks/pull/3


## Q&A, Other

* Expensive `isTraceHTTPEnable` [#81](https://github.com/nodejs/performance/issues/81)
* Vinicius will lead the implementation with the support from Yagiz


## Upcoming Meetings

* **Node.js Foundation Calendar**: https://nodejs.org/calendar

Click `+GoogleCalendar` at the bottom right to add to your own Google calendar.