This repository was archived by the owner on Aug 11, 2020. It is now read-only.
quic: client should work when receives invalid preferred address #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we set `preferredAddressPolicy` to `accept` on `QuicClientSession` but receives an invalid preferred address, e.g. we don't define `preferredAddress` on the server, the `QuicClientSession` should still work. Before this PR, the included test will cause segmetation fault.
oyyd
commented
Oct 7, 2019
| @@ -200,7 +200,7 @@ class SocketAddress { | |||
| } | |||
|
|
|||
| char host[NI_MAXHOST]; | |||
| if (uv_inet_ntop(af, binaddr, host, sizeof(host)) == 0) | |||
| if (uv_inet_ntop(af, binaddr, host, sizeof(host)) != 0) | |||
There was a problem hiding this comment.
This seems to be missed from the last rebasing. Refs: https://github.com/nodejs/quic/pull/139/files
jasnell
approved these changes
Oct 7, 2019
jasnell
pushed a commit
that referenced
this pull request
Oct 9, 2019
If we set `preferredAddressPolicy` to `accept` on `QuicClientSession` but receives an invalid preferred address, e.g. we don't define `preferredAddress` on the server, the `QuicClientSession` should still work. Before this PR, the included test will cause segmetation fault. PR-URL: #155 Reviewed-By: James M Snell <[email protected]>
|
Landed |
addaleax
pushed a commit
that referenced
this pull request
Dec 11, 2019
If we set `preferredAddressPolicy` to `accept` on `QuicClientSession` but receives an invalid preferred address, e.g. we don't define `preferredAddress` on the server, the `QuicClientSession` should still work. Before this PR, the included test will cause segmetation fault. PR-URL: #155 Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
If we set `preferredAddressPolicy` to `accept` on `QuicClientSession` but receives an invalid preferred address, e.g. we don't define `preferredAddress` on the server, the `QuicClientSession` should still work. Before this PR, the included test will cause segmetation fault. PR-URL: nodejs#155 Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
If we set `preferredAddressPolicy` to `accept` on `QuicClientSession` but receives an invalid preferred address, e.g. we don't define `preferredAddress` on the server, the `QuicClientSession` should still work. Before this PR, the included test will cause segmetation fault. PR-URL: nodejs#155 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we set
preferredAddressPolicytoacceptonQuicClientSessionbut receives an invalid preferred address, e.g. we don't define
preferredAddresson the server, theQuicClientSessionshould stillwork. Before this PR, the included test will cause segmetation fault.
the example in
ngtcp2always return 0 onselect_preferred_address: https://github.com/ngtcp2/ngtcp2/blob/52d56a90a7766c71c68362dc85f5fdc866760f47/examples/client.cc#L673Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes