Add Ulises missing key to README. #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Oct 2, 2023
README.md
Outdated
Comment on lines
54
to
55
| * **Ulises Gascón** <[email protected]> | ||
| [`A363A499291CBBC940DD62E41F10027AF002F8B0`](https://raw.githubusercontent.com/nodejs/release-keys/HEAD/keys/A363A499291CBBC940DD62E41F10027AF002F8B0.asc) |
There was a problem hiding this comment.
This should be in the primary list of keys above.
There was a problem hiding this comment.
@richardlau Apologies!! Thank you for spotting, new commit incoming.
There was a problem hiding this comment.
@richardlau That's that moved.
richardlau
approved these changes
Oct 2, 2023
UlisesGascon
approved these changes
Jan 22, 2025
|
@UlisesGascon can you please merge this with fast-forward so the commit landing on # Reset your local clone to this PR head
git fetch https://github.com/nodejs/release-keys.git b8fad3a99e778661a6f2da49fcd9a04b7992f38b
git reset FETCH_HEAD --hard
# Squash the two commits, fix the commit message
git reset HEAD^ --soft
git commit --amend -m 'doc: add updated release key for UlisesGascon'
# Rebase and sign (you might need to pass the actual key to the git command if you have several keys)
git fetch https://github.com/nodejs/release-keys.git HEAD
git rebase -S FETCH_HEAD
# Force push this PR (in this example, using SSH, maybe you'd prefer to use HTTPS instead)
git push [email protected]:easkay/release-keys.git HEAD:update_readme_list -f
# Push to main
git push [email protected]:nodejs/release-keys.git HEAD:main |
UlisesGascon
force-pushed
the
update_readme_list
branch
from
b245a01 to
08bb369
Compare
|
It worked perfect! Thanks for all the detailed instructions @aduh95 ❤️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ulises Gascón added their key in #25 and the README in https://github.com/nodejs/node was updated, but not here.