-
-
Notifications
You must be signed in to change notification settings - Fork 8
Add OpenJS Foundation Collaborator Summit: Dublin notes #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
# Node.js Single-Executable OpenJS Mini-summit 2022-10-01 | ||
|
||
## Present | ||
|
||
* Michael Dawson @mhdawson | ||
* Darshan Sen @RaisinTen | ||
* Juan Cruz Viotti @jviotti | ||
* Claudio Wunder @ovflowd | ||
* Ruy Adorno @ruyadorno | ||
* Orta Therox @orta | ||
* Tierney Cyren @bnb | ||
jviotti marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* Tobias Nießen @tniessen | ||
* Tony Gorez @tony-go | ||
* Anton Whalley @No9 | ||
* Waleed Ashraf @WaleedAshraf | ||
|
||
## Notes | ||
|
||
- There is general agreement that we want to try as hard as possible to make | ||
SEAs truly "single executable" without additional resources | ||
- There is agreement that we don't want Node.js to support a single specific | ||
blessed VFS. Instead, Node.js should aim to provide the necessary hooks for | ||
supporting arbitrary VFS implementations | ||
- Teaching Node.js how to transparently work with a VFS on `fs`, `require`, | ||
`import` and `child_process` is non-trivial. We agreed that we do not want | ||
implementations to continue monkey-patching these modules and that | ||
monkey-patching will not work with ESM at all | ||
- Exposing hooking capabilities is a complex problem. While we agree that a VFS | ||
is essential for supporting dynamic requires, read operations, etc we believe | ||
that there is a significant number of Node.js CLIs that might not need this | ||
- Therefore, we can explore delivering an MVP without a VFS while we continue | ||
thinking about how we'll do VFS properly | ||
- This MVP would assume that apps are bundled into a single JavaScript file | ||
before injection | ||
- Node.js core would take a small patch to detect a single file embedded as a | ||
section and jump to it if found | ||
- In the interest of making Node.js binaries smaller without operating custom | ||
Node.js builds, we will move the ICU data into a new section, so it can be | ||
replaced by the ICU "small" data (or removed?) if needed post-compilation | ||
rather than at build-time | ||
- We expect that distributing Node.js injected binaries to user computers will | ||
come with challenges we want to solve in advance. For example, Windows PE | ||
binaries including plain JavaScript tend to be flagged by AntiViruses as | ||
trojans. We will start maintaining a list of these challenges and then try to | ||
figure out how to incrementally solve them. | ||
|
||
## Action Items | ||
|
||
- Send patch to https://github.com/nodejs/node to detect and jump to a section | ||
containing a single JavaScript file if found | ||
(https://github.com/nodejs/single-executable/issues/47) | ||
- Collect a list of potential problems we would face when distributing Node.js | ||
injected binaries to user computers across operating systems | ||
(https://github.com/nodejs/single-executable/issues/46) | ||
- Split Node.js ICU data into its own section (so we can fiddle with it with | ||
Postject) (https://github.com/nodejs/single-executable/issues/48) | ||
- @No9 to connect us with IBM AIX folks to understand the need for SEAs on AIX | ||
(and potential XCOFF help?) | ||
- Start working on a proper "SEA" CLI MVP that can bundle and inject simple | ||
Node.js applications (https://github.com/nodejs/single-executable/issues/49) | ||
|
||
## Other Ideas | ||
|
||
- We could explore splitting different Node.js modules (like `fs`) into | ||
separate sections to strip them out for applications that do not need them | ||
- We could explore a different mechanism for loading native add-ons in order to | ||
embed them into the executable itself. For example, marking the corresponding | ||
sections as readable + executable and doing a long jump to the instructions | ||
corresponding to the add-ons instead of using `dlopen`, etc |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I missed anybody, but let me know if so