Semver Major Considerations

[ronag]

Based on my experience working with undici through nxt-undici and building a more advanced client on top undici I have come to a few realizations that have semver major implications:

• onBodySent and onRequestSent are huge footguns. Remove it. (just wrap the body)
• interceptors are weird and overengineered. Remove it. (just wrap dispatchers)
• onConnect is confusing and should be renamed or something to make it more intuitive. Possibly entirely removed.
• body should support a factory method (important for retries and redirects).
• onResponseStarted. Why is onHeaders insufficient?
• maxRedirections and RedirectHandler should not be part of core/dispatcher APi. Move to the api methods.
• Change hooks signature to accept objects instead of params.
• Rename disatpcher param to dispatch which is just a function (opts, handler) => {}

[metcoder95]

onBodySent and onRequestSent are huge footguns. Remove it. (just wrap the body)

SGTM, left some thoughts on the PR 👍

interceptors are weird and overengineered. Remove it. (just wrap dispatchers)

Agree, wrapping dispatches providers' full ergonomics. The interceptors feel like a half-baked feature sadly

onConnect is confusing and should be renamed or something to make it more intuitive. Possibly entirely removed.

What's the problem that surfaces from it?
Renaming it seems fair, but curious about what's the exact problem there

body should support a factory method (important for retries and redirects).

Maybe we can refactor it to a base class and do something similar as we do already for the Dispatcher?

onResponseStarted. Why is onHeaders insufficient?

I kind of remember this PR; I believe it is mostly around documenting what onHeaders can be used for beyond receiving and parsing the headers.

maxRedirections and RedirectHandler should not be part of core/dispatcher APi. Move to the api methods.

Do you mean to implement them within each of the APIs or just export a new one?

Do we have a timeline for the next major version?
Or maybe we can make this list the requirements for the next major?

[ronag]

@metcoder95 do you think you could help me with a PR removing the interceptor stuff?

[Uzlopak]

If we consider undici major version, than maybe target llhttp 9 upgrade to the next branch?!

@ShogunPanda
@mcollina

[metcoder95]

Sure, I can have something prepared for next week 👍

[metcoder95]

If we consider undici major version, than maybe target llhttp 9 upgrade to the next branch?!

I believe that yes, but also with the considerations from @mcollina