fix: remove deprecated maxRedirections option from types #4363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maxRedirections option was removed in v7 but still remained in TypeScript type definitions. This removes it from: - Agent.Options and Agent.DispatchOptions - Dispatcher ConnectOptions, RequestOptions, and UpgradeOptions - Client.Options and H2CClient.Options - MockInterceptor.MockResponseCallbackOptions Also updates corresponding type tests to remove usage of the deprecated option. The redirect interceptor still supports maxRedirections as that functionality remains available. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
|
@metcoder95 good spot! |
metcoder95
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
maxRedirectionsoption from TypeScript type definitionsmaxRedirectionsin redirect interceptor where it's still validTest plan
npm run test:typescript)npm run lint)maxRedirectionsremoved from public API types🤖 Generated with Claude Code