Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/core/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ for (let i = 0; i < wellknownHeaderNames.length; ++i) {
const lowerCasedKey = key.toLowerCase()
headerNameLowerCasedRecord[key] = headerNameLowerCasedRecord[lowerCasedKey] =
lowerCasedKey
wellknownHeaderNameBuffers[lowerCasedKey] = Buffer.from(lowerCasedKey)
}

module.exports = {
Expand Down
25 changes: 25 additions & 0 deletions test/node-test/constants.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
'use strict'

const { test } = require('node:test')
const assert = require('node:assert')
const {
wellknownHeaderNames,
getHeaderNameAsBuffer
} = require('../../lib/core/constants')

test('getHeaderNameAsBuffer returns cached buffer for well-known headers', () => {
for (let i = 0; i < wellknownHeaderNames.length; ++i) {
const lowerCased = wellknownHeaderNames[i].toLowerCase()
const first = getHeaderNameAsBuffer(lowerCased)
const second = getHeaderNameAsBuffer(lowerCased)
assert.ok(Buffer.isBuffer(first))
assert.strictEqual(first.toString(), lowerCased)
assert.strictEqual(first, second, `expected cached buffer for ${lowerCased}`)
}
})

test('getHeaderNameAsBuffer allocates a new buffer for unknown headers', () => {
const buffer = getHeaderNameAsBuffer('x-custom-not-well-known')
assert.ok(Buffer.isBuffer(buffer))
assert.strictEqual(buffer.toString(), 'x-custom-not-well-known')
})
Loading