fix(websocket): use 1002 close code on parser errors#5051
Open
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Open
fix(websocket): use 1002 close code on parser errors#5051deepview-autofix wants to merge 1 commit intonodejs:mainfrom
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Conversation
onParserError passed null as the close code to failWebsocketConnection,
causing closeWebSocketConnection to default the code to 1000 ("Normal
Closure") whenever the reason string was non-empty. Protocol errors
(invalid frames, RSV bit violations, etc.) surfaced through the parser
were thus reported to the peer as normal closures instead of 1002
("Protocol Error"), violating RFC 6455 section 7.4.1.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com>
Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com>
Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5051 +/- ##
=======================================
Coverage 93.03% 93.03%
=======================================
Files 110 110
Lines 35793 35793
=======================================
+ Hits 33299 33300 +1
+ Misses 2494 2493 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Instead of a simulated error, could we test for one of the following?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onParserError passed null as the close code to failWebsocketConnection, causing closeWebSocketConnection to default the code to 1000 ("Normal Closure") whenever the reason string was non-empty. Protocol errors (invalid frames, RSV bit violations, etc.) surfaced through the parser were thus reported to the peer as normal closures instead of 1002 ("Protocol Error"), violating RFC 6455 section 7.4.1.