fix: destroy IncomingMessage and invalid assertion#834
Merged
Conversation
Change so that we destroy IncomingMessage without closing the socket. Also fixes an invalid assertion that was triggered by the test.
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
==========================================
+ Coverage 99.56% 99.95% +0.39%
==========================================
Files 26 26
Lines 2048 2048
==========================================
+ Hits 2039 2047 +8
+ Misses 9 1 -8
Continue to review full report at Codecov.
|
Member
Author
|
sigh? 😕 |
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
Change so that we destroy IncomingMessage without closing the socket. Also fixes an invalid assertion that was triggered by the test.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change so that we destroy IncomingMessage without closing the
socket. Also fixes an invalid assertion that was triggered by
the test.