Add canny edges filter #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice PR! The img->canvas and video->canvas utils that you built in could be useful to extract out as separate components or subgraphs. What do you think? There is already the UrlToCanvas graph. |
|
Hi @forresto, thanks! I agree with you and will give it a try :) |
|
Updated the PR to include
|
|
Sorry for the lag... you know why! |
forresto
added a commit
that referenced
this pull request
Oct 16, 2014
* new In/OutPorts format * shutdown method is good to have for well-behaved components with timeouts, rAF, etc. * optional canvas input to draw to canvas already in DOM * only create one canvas, send it to output on every draw * only draw and send if video time has changed * TODO spec!
|
I ended up changing a bunch in VideoToCanvas, check it out. |
|
Really cool changes @forresto :) thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I am going to MozFest together with @forresto, @automata and maybe more of you :), so I am planning to create some filters to work on the Turtle Power installation/workshop.
This one is a canny edge detector from JSFeat, and the image below shows it working on Flowhub.
Also, I wanted to create a test, but I ended up with a problem on node-canvas (Automattic/node-canvas#476) so I committed only a simple version of the test, but the full version is on https://gist.github.com/GabiThume/335eabfc5fd440242b89 for later.